Skip to content

Conversation

@mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Dec 3, 2025

@mmorel-35
Copy link
Author

/cc @BYVoid

@lemire
Copy link
Member

lemire commented Dec 4, 2025

As such, this will not work, of course.

@mmorel-35
Copy link
Author

mmorel-35 commented Dec 6, 2025

That's based on @BYVoid work in BCR.

Can you provide some guidance to make this work ?

@mmorel-35 mmorel-35 force-pushed the bcr branch 2 times, most recently from 2351ab7 to eba6e93 Compare December 6, 2025 11:10
@lemire
Copy link
Member

lemire commented Dec 6, 2025

@mmorel-35

That's based on @BYVoid work in BCR. Can you provide some guidance to make this work ?

This will not work because your configuration requires a secret token: BCR_PUBLISH_TOKEN. If you have this secret token, you can communicate with me privately and share it with me, and I can add it to the repo.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Comment on lines +52 to +77
### Creating a Personal Access Token

1. **Navigate to GitHub Settings**
- Go to https://github.com/settings/tokens
- Or: Click your profile picture → Settings → Developer settings → Personal access tokens → Tokens (classic)

2. **Generate New Token**
- Click "Generate new token (classic)"
- Give it a descriptive name, e.g., "BCR Publishing for fast_float"
- Set an appropriate expiration (recommended: 1 year with calendar reminder to renew)

3. **Select Required Scopes**
- ✅ **`repo`** (Full control of private repositories) - Required for accessing repository details
- ✅ **`workflow`** (Update GitHub Action workflows) - Required for the publishing action

4. **Generate and Copy**
- Click "Generate token" at the bottom
- **Important**: Copy the token immediately - you won't be able to see it again!

5. **Add as Repository Secret**
- Go to the fast_float repository settings
- Navigate to: Settings → Secrets and variables → Actions
- Click "New repository secret"
- Name: `BCR_PUBLISH_TOKEN`
- Value: Paste the token you copied
- Click "Add secret"
Copy link
Author

@mmorel-35 mmorel-35 Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not allowed to provide the token, this is a task for fast_float project maintainer, see this

@lemire
Copy link
Member

lemire commented Dec 6, 2025

@LeszekSwirski can you review this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants