Pylint issues

[ross-spencer]

Adding better CI has shown (previously just highly anticipated) some legacy linting issues. They should all have pretty quick fixes but I haven't time today.

NB. for the unit tests, need to double check they've all been converted to pytest format.
NB. another thing to look at is there are a lot of legacy exceptions in .pylintrc from demystify. We can remove those and then fix those at the same time.

************* Module sqlitefid.libs.FidoLoaderClass
src/sqlitefid/libs/FidoLoaderClass.py:52:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module sqlitefid.libs.DROIDLoaderClass
src/sqlitefid/libs/DROIDLoaderClass.py:123:12: R1703: The if statement can be replaced with 'var = bool(test)' (simplifiable-if-statement)
src/sqlitefid/libs/DROIDLoaderClass.py:161:28: R1703: The if statement can be replaced with 'var = bool(test)' (simplifiable-if-statement)
src/sqlitefid/libs/DROIDLoaderClass.py:107:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
src/sqlitefid/libs/DROIDLoaderClass.py:196:38: E0601: Using variable 'MULTIPLE_KEY_LIST' before assignment (used-before-assignment)
src/sqlitefid/libs/DROIDLoaderClass.py:198:48: E0601: Using variable 'MULTIPLE_VALUE_LIST' before assignment (used-before-assignment)
************* Module tests.test_utilities
tests/test_utilities.py:80:10: W0212: Access to a protected member _id_object_in_container of a client class (protected-access)
************* Module sqlitefid.libs.IdentifyExportClass
src/sqlitefid/libs/IdentifyExportClass.py:61:4: R0911: Too many return statements (7/6) (too-many-return-statements)
************* Module sqlitefid.libs.GenerateBaselineDBClass
src/sqlitefid/libs/GenerateBaselineDBClass.py:12:0: R0904: Too many public methods (21/20) (too-many-public-methods)
************* Module setup
setup.py:5:0: E0401: Unable to import 'setuptools' (import-error)
setup.py:12:5: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
setup.py:13:4: W0122: Use of exec (exec-used)
************* Module sqlitefid.libs.SFLoaderClass
src/sqlitefid/libs/SFLoaderClass.py:178:40: E0606: Possibly using variable 'idkey' before assignment (possibly-used-before-assignment)
src/sqlitefid/libs/SFLoaderClass.py:180:69: E0606: Possibly using variable 'idvalue' before assignment (possibly-used-before-assignment)
************* Module sqlitefid.libs.CSVHandlerClass
src/sqlitefid/libs/CSVHandlerClass.py:91:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
src/sqlitefid/libs/CSVHandlerClass.py:114:16: R1702: Too many nested blocks (7/5) (too-many-nested-blocks)
************* Module sqlitefid.libs.SFHandlerClass
src/sqlitefid/libs/SFHandlerClass.py:9:0: R0022: Useless option value for 'disable', 'W1658' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/4942. (useless-option-value)
src/sqlitefid/libs/SFHandlerClass.py:224:24: E0606: Possibly using variable 'id_record' before assignment (possibly-used-before-assignment)
src/sqlitefid/libs/SFHandlerClass.py:303:12: W0107: Unnecessary pass statement (unnecessary-pass)
src/sqlitefid/libs/SFHandlerClass.py:507:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
src/sqlitefid/libs/SFHandlerClass.py:518:12: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
src/sqlitefid/libs/SFHandlerClass.py:488:4: R0911: Too many return statements (9/6) (too-many-return-statements)
src/sqlitefid/libs/SFHandlerClass.py:550:4: R0911: Too many return statements (12/6) (too-many-return-statements)
************* Module tests.test_fido_handler
tests/test_fido_handler.py:35:10: W0212: Access to a protected member _csv_to_list of a client class (protected-access)
tests/test_fido_handler.py:45:10: W0212: Access to a protected member _csv_to_list of a client class (protected-access)