Merge branch 'main' into alex/2609_hints

* main:
  chore: fix some minor issues in the comments (#2955)
  feat: make reaper poll duration configurable (#2951)
  chore!: move sequencers to pkg (#2931)
  feat: Ensure Header integrity on DA (#2948)
  feat(testda): add header support with GetHeaderByHeight method (#2946)
  chore: improve code comments clarity (#2947)
  chore(sequencers): optimize store check (#2945)

Author: alpe

.gitignore

@@ -1,4 +1,5 @@
 coverage.txt
+*.out
 proto/pb
 proto/tendermint
 types/pb/tendermint
@@ -30,3 +31,4 @@ docs/.vitepress/cache
 .claude
 .gocache
 .gomodcache
+/.cache

CLAUDE.md

@@ -44,15 +44,15 @@ The project uses a zero-dependency core package pattern:
 
 - **core/** - Contains only interfaces and types, no external dependencies
 - **block/** - Block management, creation, validation, and synchronization
-- **p2p/** - Networking layer built on libp2p
-- **sequencing/** - Modular sequencer implementations
-- **testapp/** - Reference implementation for testing
+- **pkg/p2p/** - Networking layer built on libp2p
+- **pkg/sequencers/** - Modular sequencer implementations
+- **apps/testapp/** - Reference implementation for testing
 
 ### Key Interfaces
 
-- **Executor** (core/executor.go) - Handles state transitions
-- **Sequencer** (core/sequencer.go) - Orders transactions
-- **DA** (pkg/da/types) - Data availability layer abstraction
+- **Executor** (`core/executor.go`) - Handles state transitions
+- **Sequencer** (`core/sequencer.go`) - Orders transactions
+- **DA** (`pkg/da/types`) - Data availability layer abstraction
 
 ### Modular Design
 

apps/evm/cmd/run.go

@@ -26,9 +26,9 @@ import (
 	genesispkg "github.com/evstack/ev-node/pkg/genesis"
 	"github.com/evstack/ev-node/pkg/p2p"
 	"github.com/evstack/ev-node/pkg/p2p/key"
+	"github.com/evstack/ev-node/pkg/sequencers/based"
+	"github.com/evstack/ev-node/pkg/sequencers/single"
 	"github.com/evstack/ev-node/pkg/store"
-	"github.com/evstack/ev-node/sequencers/based"
-	"github.com/evstack/ev-node/sequencers/single"
 
 	"github.com/evstack/ev-node/apps/evm/server"
 )

apps/grpc/Dockerfile

@@ -12,7 +12,6 @@ COPY go.mod go.sum ./
 COPY apps/grpc/go.mod apps/grpc/go.sum ./apps/grpc/
 COPY core/go.mod ./core/
 COPY execution/grpc/go.mod execution/grpc/go.sum ./execution/grpc/
-COPY sequencers/single/go.mod sequencers/single/go.sum ./sequencers/single/
 
 # Download dependencies
 RUN go mod download

apps/grpc/README.md

@@ -151,4 +151,4 @@ If you have issues connecting to the DA layer:
 
 - [Evolve Documentation](https://ev.xyz)
 - [gRPC Execution Interface](../../execution/grpc/README.md)
-- [Single Sequencer Documentation](../../sequencers/single/README.md)
+- [Single Sequencer Documentation](../../pkg/sequencers/single/README.md)

apps/grpc/cmd/run.go

@@ -22,9 +22,9 @@ import (
 	rollgenesis "github.com/evstack/ev-node/pkg/genesis"
 	"github.com/evstack/ev-node/pkg/p2p"
 	"github.com/evstack/ev-node/pkg/p2p/key"
+	"github.com/evstack/ev-node/pkg/sequencers/based"
+	"github.com/evstack/ev-node/pkg/sequencers/single"
 	"github.com/evstack/ev-node/pkg/store"
-	"github.com/evstack/ev-node/sequencers/based"
-	"github.com/evstack/ev-node/sequencers/single"
 )
 
 const (

apps/testapp/cmd/run.go

@@ -20,9 +20,9 @@ import (
 	"github.com/evstack/ev-node/pkg/genesis"
 	"github.com/evstack/ev-node/pkg/p2p"
 	"github.com/evstack/ev-node/pkg/p2p/key"
+	"github.com/evstack/ev-node/pkg/sequencers/based"
+	"github.com/evstack/ev-node/pkg/sequencers/single"
 	"github.com/evstack/ev-node/pkg/store"
-	"github.com/evstack/ev-node/sequencers/based"
-	"github.com/evstack/ev-node/sequencers/single"
 )
 
 const testDbName = "testapp"

block/components.go

@@ -226,7 +226,7 @@ func NewAggregatorComponents(
 		logger,
 		executor,
 		cacheManager,
-		reaping.DefaultInterval,
+		config.Node.ScrapeInterval.Duration,
 	)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create reaper: %w", err)

block/internal/reaping/reaper.go

@@ -19,12 +19,8 @@ import (
 )
 
 const (
-	// DefaultInterval is the default reaper interval
-	DefaultInterval = 1 * time.Second
 	// MaxBackoffInterval is the maximum backoff interval for retries
 	MaxBackoffInterval = 30 * time.Second
-	// BackoffMultiplier is the multiplier for exponential backoff
-	BackoffMultiplier = 2
 )
 
 // Reaper is responsible for periodically retrieving transactions from the executor,

block/internal/submitting/da_submitter.go

@@ -8,7 +8,6 @@ import (
 	"time"
 
 	"github.com/rs/zerolog"
-	"google.golang.org/protobuf/proto"
 
 	"github.com/evstack/ev-node/block/internal/cache"
 	"github.com/evstack/ev-node/block/internal/common"
@@ -171,7 +170,7 @@ func (s *DASubmitter) recordFailure(reason common.DASubmitterFailureReason) {
 }
 
 // SubmitHeaders submits pending headers to DA layer
-func (s *DASubmitter) SubmitHeaders(ctx context.Context, cache cache.Manager) error {
+func (s *DASubmitter) SubmitHeaders(ctx context.Context, cache cache.Manager, signer signer.Signer) error {
 	headers, err := cache.GetPendingHeaders(ctx)
 	if err != nil {
 		return fmt.Errorf("failed to get pending headers: %w", err)
@@ -181,15 +180,29 @@ func (s *DASubmitter) SubmitHeaders(ctx context.Context, cache cache.Manager) er
 		return nil
 	}
 
+	if signer == nil {
+		return fmt.Errorf("signer is nil")
+	}
+
 	s.logger.Info().Int("count", len(headers)).Msg("submitting headers to DA")
 
 	return submitToDA(s, ctx, headers,
 		func(header *types.SignedHeader) ([]byte, error) {
-			headerPb, err := header.ToProto()
+			// A. Marshal the inner SignedHeader content to bytes (canonical representation for signing)
+			// This effectively signs "Fields 1-3" of the intended DAHeaderEnvelope.
+			contentBytes, err := header.MarshalBinary()
 			if err != nil {
-				return nil, fmt.Errorf("failed to convert header to proto: %w", err)
+				return nil, fmt.Errorf("failed to marshal signed header for envelope signing: %w", err)
 			}
-			return proto.Marshal(headerPb)
+
+			// B. Sign the contentBytes with the envelope signer (aggregator)
+			envelopeSignature, err := signer.Sign(contentBytes)
+			if err != nil {
+				return nil, fmt.Errorf("failed to sign envelope: %w", err)
+			}
+
+			// C. Create the envelope and marshal it
+			return header.MarshalDAEnvelope(envelopeSignature)
 		},
 		func(submitted []*types.SignedHeader, res *datypes.ResultSubmit) {
 			hashes := make([]types.Hash, len(submitted))