If apply_all_transactions is missing data, reraise

carver · carver · commit 53accba2b7a5 · 2019-12-06T10:56:50.000-08:00
Just continuing is all kinds of wrong. I don't know how this bug lasted
so long. I guess it's not tested or used often.

It caused some unfortunate bugs for lithp that were hard to track down,
because the state got reverted, but the receipt was still added. Sorry,
buddy!
diff --git a/eth/vm/base.py b/eth/vm/base.py
@@ -231,6 +231,7 @@ def apply_all_transactions(
                 )
             except EVMMissingData as exc:
                 self.state.revert(snapshot)
+                raise
 
             result_header = self.add_receipt_to_header(previous_header, receipt)
             previous_header = result_header
diff --git a/newsfragments/1889.bugfix.rst b/newsfragments/1889.bugfix.rst
@@ -0,0 +1,3 @@
+Bug: if data was missing during a call to :meth:`~eth.vm.base.VM.apply_all_transactions`,
+then the call would revert and continue processing transactions. Fix: we re-raise
+the :class:`~eth.exceptions.EVMMissingData` and do not continue processing transactions.

Original file line number	Diff line number	Diff line change
`@@ -231,6 +231,7 @@ def apply_all_transactions(`
`231`	`231`	`)`
`232`	`232`	`except EVMMissingData as exc:`
`233`	`233`	`self.state.revert(snapshot)`
	`234`	`+ raise`
`234`	`235`
`235`	`236`	`result_header = self.add_receipt_to_header(previous_header, receipt)`
`236`	`237`	`previous_header = result_header`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+Bug: if data was missing during a call to :meth:`~eth.vm.base.VM.apply_all_transactions`,
	`2`	`+then the call would revert and continue processing transactions. Fix: we re-raise`
	`3`	+the :class:`~eth.exceptions.EVMMissingData` and do not continue processing transactions.