Skip to content

Commit 3fefd39

Browse files
committed
Fix lint
1 parent d0bbe4e commit 3fefd39

File tree

17 files changed

+127
-112
lines changed

17 files changed

+127
-112
lines changed

.local.dic

Lines changed: 58 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
1+
*google
2+
*NPM
13
2FA
24
30KB
35
activations
4-
acyclic
56
ActiveSupport
7+
acyclic
68
Algolia
7-
asynchronicity
89
Americentric
10+
asynchronicity
911
asynchrony
10-
autocomplete
11-
autotrack
1212
auto-rollup
13+
autocomplete
14+
autocompletion
1315
autoruns
16+
autotrack
1417
autotracking
1518
aXe
1619
backticks
@@ -24,8 +27,8 @@ camelize
2427
Chai
2528
chainable
2629
cheatsheet
27-
Checkboxes
2830
checkboxes
31+
Checkboxes
2932
coc-ember
3033
CoffeeScript
3134
ColorSafe
@@ -44,31 +47,37 @@ datepicker
4447
de
4548
debounce
4649
declaratively
50+
DefinitelyTyped
4751
deps
4852
draggable
53+
dropdown
4954
durations
55+
dynamicness
5056
EditorConfig
5157
els-addon-docs
5258
els-addon-typed-templates
53-
enumerables
5459
ember-a11y
5560
ember-a11y-refocus
5661
ember-a11y-testing
57-
ember-cli-deprecation-workflow
5862
ember-cli-cjs-transform
63+
ember-cli-deprecation-workflow
5964
ember-cli-document-title
6065
ember-cli-head
6166
ember-cli-htmlbars
62-
ember-cli-netlify
6367
ember-cli-mirage.
68+
ember-cli-netlify
6469
ember-cli-tutorial-style
70+
ember-cli-typescript
6571
ember-debug-handlers-polyfill
6672
ember-fast-cli
6773
ember-intl
6874
EmberData
75+
EmberObject
76+
enumerables
6977
erroring
7078
Evented
7179
facto
80+
fallbacks
7281
FastPass
7382
favicon
7483
Favicon
@@ -82,11 +91,10 @@ geocoding
8291
getter
8392
getters
8493
Getters
85-
GitLab
8694
GIFs
87-
globbing
95+
GitLab
8896
GlimmerX
89-
*google
97+
globbing
9098
hackable
9199
HammerJS
92100
hardcode
@@ -95,25 +103,30 @@ Hm
95103
Hoc
96104
htmlbars
97105
IE11
98-
interop
99-
interoperable
100-
invocable
101-
invoker
102106
IndexedDB
103107
Inflector
104108
instantiation
105109
Intellisense
110+
IntelliSense
111+
interop
112+
interoperable
113+
invokable
114+
invokables
115+
invoker
106116
invoker
107117
invokers
118+
JetBrains
108119
jquery-integration
120+
JSDoc
109121
keyCode
110122
KVO
111123
lang
112124
linters
113-
LSP
114125
lookups
126+
LSP
115127
Mapbox
116128
MDN
129+
metaprogramming
117130
misspelt
118131
mixin
119132
mixins
@@ -123,103 +136,108 @@ natively
123136
nav
124137
nav-bar
125138
Neovim
126-
*NPM
127139
NVDA
128140
onboarding
129141
Orca
130142
page-crafter
131143
parallelize
132-
Param
133144
param
134-
params
145+
Param
135146
parameterizing
147+
params
136148
PascalCased
137149
pipelining
138150
PR
139-
PRs
140-
preload
141-
prepend
142-
prepended
143151
pre-determined
152+
pre-octane
144153
pre-populating
145154
pre-transition
155+
pre-transition
156+
preload
157+
prepend
158+
prepended
146159
presentational
147160
Presentational
148-
pre-transition
149-
pre-octane
161+
PRs
150162
readme
151163
readonly
152164
recognizers
165+
recursing
153166
Redux
154167
relayout
155168
renderer
156169
repo
157170
repos
158171
rerender
159-
rerenders
160172
rerendering
173+
rerenders
161174
routable
162175
RunDOC
163-
Runnable
164176
runnable
177+
Runnable
165178
runtime
166179
sandboxed
167180
scp
168181
screencasting
169182
selectable
183+
self-referentiality
170184
serverless
171185
singularize
172-
source-readibility
173186
Splattributes
174187
SSR
175188
stateful
189+
subclassed
176190
subclasses
177191
subclassing
178192
subdomain
179193
subexpression
180-
substring
181194
subfolders
182195
suboptimal
183196
subroutes
184197
substate
185198
substates
199+
substring
186200
SuperForm
201+
superset
202+
swappable
187203
synergistically
188204
syntaxes
189-
swappable
190205
tagless
191206
TalkBack
192207
teardown
208+
template-lifecycle-dom-and-modifiers
193209
templating
194210
todo
195211
todos
196-
treesitter
197-
triple-backtick
198212
tooltip
199213
trackable
200214
Trackable
201215
Treeshaking
216+
treesitter
217+
triple-backtick
202218
typeahead
219+
typechecker
220+
typings
203221
UIs
204-
URL-escaped
222+
un-representable
205223
unordered
206224
unsilence
207225
unstyled
208226
untracked
209227
untrusted
228+
URL-escaped
210229
usecase
230+
v1
231+
v2
211232
viewport
212233
vim-ember-hbs
213234
vim-javascript
214235
vim-js-pretty-template
215236
VM
216-
Voilà
217-
voilà
218237
VoiceOver
238+
voilà
239+
Voilà
219240
websocket
220-
Websockets
221-
ZEIT
222-
yay
223-
template-lifecycle-dom-and-modifiers
224241
working-with-html-css-and-javascript
225-
dropdown
242+
yay
243+
ZEIT

guides/release/code-editors/index.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Stable Ember Language Server is a stable, full-featured language server. Its nam
2525

2626
### Workflow
2727

28-
[ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) - Integrates ESLint into VS Code.
28+
[ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) - Integrates ESLint into VS Code.
2929

3030
[EditorConfig for Visual Studio Code](https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig) -
3131
Attempts to override user/workspace settings with settings found in `.editorconfig` files.
@@ -49,8 +49,7 @@ Prettier is an opinionated code formatting tool. It enforces a consistent style
4949
</div>
5050
</div>
5151

52-
53-
[Glint](https://marketplace.visualstudio.com/items?itemName=typed-ember.glint-vscode) is a set of tools to aid in developing code that uses the Glimmer VM for rendering, such as Ember.js v3.24+ and GlimmerX projects.
52+
[Glint](https://marketplace.visualstudio.com/items?itemName=typed-ember.glint-vscode) is a set of tools to aid in developing code that uses the Glimmer VM for rendering, such as Ember.js v3.24+ and GlimmerX projects.
5453

5554
## Vim and Neovim
5655

@@ -76,10 +75,10 @@ or
7675
[vim-ember-hbs](https://github.com/joukevandermaas/vim-ember-hbs) -
7776
Add Ember template syntax highlighting and indentation to Vim.
7877
To get embedded highlighting will involve these additional plugins:
78+
7979
- [vim-javascript](https://github.com/pangloss/vim-javascript)
8080
- [vim-js-pretty-template](https://github.com/Quramy/vim-js-pretty-template)
8181

82-
8382
### Language Server
8483

8584
Only one of these solutions should be used at a time.
@@ -91,21 +90,18 @@ Example mason+LSP config [can be found here](https://github.com/NullVoxPopuli/do
9190
or
9291

9392
[Conquer for Completion (COC) for Neovim](https://github.com/neoclide/coc.nvim) -
94-
An Intellisense engine which takes control over all linting, hinting, and language-server integration.
93+
An IntelliSense engine which takes control over all linting, hinting, and language-server integration.
9594
With the ember plugin [coc-ember](https://github.com/NullVoxPopuli/coc-ember) -
9695
Ember.js language server extension including useful configuration instructions.
9796

9897
### Snippets / Workflow
9998

100-
10199
[ember.vim](https://github.com/dsawardekar/ember.vim) -
102100
Shortcuts to navigate related files with Ember.js projects.
103101

104-
105102
[Ember Tools](https://github.com/AndrewRadev/ember_tools.vim) -
106103
Various tools for working with Ember.js projects.
107104

108-
109105
## Atom
110106

111107
Atom is hackable text editor for the 21st Century.

guides/release/typescript/additional-resources/faq.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ See ["Gradual Typing Hacks"][gradual-typing-hacks] for strategies for incrementa
66

77
### Install types for libraries
88

9-
You'll want to use library type definitions as much as possible. Many packages ship their own type definitions, and many others have community-maintained definitions from [DefinitelyTyped], available in the `@types` name space. The first thing you should do is to look for types from other libraries: it will mean using fewer ["Gradual Typing Hacks"][gradual-typing-hacks] and getting a lot more help both from your editor and from the compiler.
9+
You'll want to use library type definitions as much as possible. Many packages ship their own type definitions, and many others have community-maintained definitions from [DefinitelyTyped][], available in the `@types` name space. The first thing you should do is to look for types from other libraries: it will mean using fewer ["Gradual Typing Hacks"][gradual-typing-hacks] and getting a lot more help both from your editor and from the compiler.
1010

1111
### The `types` directory
1212

@@ -21,7 +21,7 @@ These are all fallbacks, of course, you should use the types supplied directly w
2121

2222
At the root of your application or addon, we include a `types/<your project>` directory with an `index.d.ts` file in it. Anything which is part of your project but which must be declared globally can go in this file. For example, if you have data attached to the `Window` object when the page is loaded (for bootstrapping or whatever other reason), this is a good place to declare it.
2323

24-
We automatically configure `index.d.ts` to be ready for [Glint], which will make type checking work with Ember's templates. The default configuration only supports Ember's classic pairing of separate `.ts` and `.hbs` files, but Glint also supports the `<template>` format with `.gts` files. See the [corresponding package README][glint-environment-ember-template-imports] for more details. (Once Ember enables `<template>` by default, so will our Glint configuration!)
24+
We automatically configure `index.d.ts` to be ready for [Glint][], which will make type checking work with Ember's templates. The default configuration only supports Ember's classic pairing of separate `.ts` and `.hbs` files, but Glint also supports the `<template>` format with `.gts` files. See the [corresponding package README][glint-environment-ember-template-imports] for more details. (Once Ember enables `<template>` by default, so will our Glint configuration!)
2525

2626
### Environment configuration typings
2727

@@ -31,7 +31,7 @@ We install this file because the actual `config/environment.js` is (a) not actua
3131

3232
## Type Narrowing with Ember Debug Assert
3333

34-
Ember's `assert` function from `@ember/debug` is super useful for ["type narrowing"][type-narrowing]—TypeScripts process of refining types to more specific types than originally declared. If youre not familiar with `assert`, you might want to take a look at its [API docs][debug-assert]! Its a development-and-test-only helper that gets stripped from production builds, and is very helpful for this kind of thing!
34+
Ember's `assert` function from `@ember/debug` is super useful for ["type narrowing"][type-narrowing]—TypeScript's process of refining types to more specific types than originally declared. If you're not familiar with `assert`, you might want to take a look at its [API docs][debug-assert]! It's a development-and-test-only helper that gets stripped from production builds, and is very helpful for this kind of thing!
3535

3636
For example, let's pretend we're writing an addon that provides a `totalLength` helper to tally up the total length of an array of strings passed to it. Because addon authors cannot guarantee that their users will be using TypeScript, we've typed the positional arguments as an array of `unknown` so that TypeScript will ensure we've handled every possible valid or invalid argument a user might pass.
3737

guides/release/typescript/additional-resources/gotchas.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ This section covers the common details and "gotchas" of using TypeScript with Em
22

33
## Registries
44

5-
Ember makes heavy use of string-based APIs to allow for a high degree of dynamicism. With some [limitations][get-set], you can nonetheless use TypeScript very effectively to get auto-complete/IntelliSense as well as to accurately type-check your applications by using **registries**.
5+
Ember makes heavy use of string-based APIs to allow for a high degree of dynamicness. With some [limitations][get-set], you can nonetheless use TypeScript very effectively to get auto-complete/IntelliSense as well as to accurately type-check your applications by using **registries**.
66

77
Here's an example defining a Shopping Cart Service in the Ember Service registry:
88

@@ -60,7 +60,7 @@ For examples, see:
6060

6161
## Templates
6262

63-
Templates are currently totally non-type-checked. This means that you lose any safety when moving into a template context, even if using a Glimmer `Component` in Ember Octane. (Looking for type-checking in templates? Try [Glint]!)
63+
Templates are currently totally non-type-checked. This means that you lose any safety when moving into a template context, even if using a Glimmer `Component` in Ember Octane. (Looking for type-checking in templates? Try [Glint][]!)
6464

6565
For example, TypeScript won't detect a mismatch between this action and the corresponding call in the template:
6666

@@ -83,7 +83,7 @@ export default class MyGame extends Component {
8383

8484
## Hook Types and Autocomplete
8585

86-
Lets imagine a component which just logs the names of its arguments when it is first constructed. First, we must define the [Signature] and pass it into our component, then we can use the `Args` member in our Signature to set the type of `args` in the constructor:
86+
Let's imagine a component which just logs the names of its arguments when it is first constructed. First, we must define the [Signature][] and pass it into our component, then we can use the `Args` member in our Signature to set the type of `args` in the constructor:
8787

8888
```typescript {data-filename="app/components/args-display.ts"}
8989
import Component from '@glimmer/component';
@@ -106,9 +106,9 @@ export default class ArgsDisplay extends Component<ArgsDisplaySignature> {
106106
}
107107
```
108108

109-
Notice that we have to start by calling `super` with `owner` and `args`. This may be a bit different from what youre used to in Ember or other frameworks, but is normal for sub-classes in TypeScript today. If the compiler just accepted any `...arguments`, a lot of potentially _very_ unsafe invocations would go through. So, instead of using `...arguments`, we explicitly pass the _specific_ arguments and make sure their types match up with what the super-class expects.
109+
Notice that we have to start by calling `super` with `owner` and `args`. This may be a bit different from what you're used to in Ember or other frameworks, but is normal for sub-classes in TypeScript today. If the compiler just accepted any `...arguments`, a lot of potentially _very_ unsafe invocations would go through. So, instead of using `...arguments`, we explicitly pass the _specific_ arguments and make sure their types match up with what the super-class expects.
110110

111-
The types for `owner` here and `args` line up with what the `constructor` for Glimmer components expects. The `owner` is specified as `unknown` because this is a detail we explicitly _dont_ need to know about. The `args` are the `Args` from the Signature we defined.
111+
The types for `owner` here and `args` line up with what the `constructor` for Glimmer components expects. The `owner` is specified as `unknown` because this is a detail we explicitly _don't_ need to know about. The `args` are the `Args` from the Signature we defined.
112112

113113
Additionally, the types of the arguments passed to subclassed methods will _not_ autocomplete as you may expect. This is because in JavaScript, a subclass may legally override a superclass method to accept different arguments. Ember's lifecycle hooks, however, are called by the framework itself, and thus the arguments and return type should always match the superclass. Unfortunately, TypeScript does not and _cannot_ know that, so we have to provide the types directly.
114114

guides/release/typescript/additional-resources/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Here are some additional resources that should be useful for using Ember with Ty
55
- [Troubleshooting][gotchas] common issues when using TypeScript with Ember.
66
- [Frequently Asked Questions][faq] users have when using TypeScript with Ember.
77
- Miscellaneous [tips][faq] for using TypeScript with Ember.
8-
- Looking for type-checking in Ember templates? Check out [Glint].
8+
- Looking for type-checking in Ember templates? Check out [Glint][].
99

1010
<!-- Internal links -->
1111

0 commit comments

Comments
 (0)