Skip to content

Commit cbf504a

Browse files
authored
Merge pull request #1324 from kategengler/kg-note-ember-string-bug
Add a warning about the current bug in the implementation of the `@ember/string` deprecation.
2 parents 3a15b01 + ed0e4f2 commit cbf504a

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

content/ember/v4/deprecate-ember-string.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,13 @@ To add the package to your project:
1919
If you were importing `htmlSafe` or `isHTMLSafe` from `@ember/string`, please
2020
import them from `@ember/template` instead. See
2121
[this deprecation guide](https://deprecations.emberjs.com/v3.x#toc_ember-string-htmlsafe-ishtmlsafe) for more information.
22+
23+
Note! As of May 19, 2023 there is a [bug](https://github.com/emberjs/ember.js/issues/20377)
24+
in the implementation of the `@ember/string` deprecation. Adding `@ember/string`
25+
to your project may not be enough to silence the deprecation. You may silence
26+
the deprecation by using [`ember-cli-deprecation-workflow`](https://github.com/mixonic/ember-cli-deprecation-workflow).
27+
28+
To upgrade to `ember-source v5.0`, ensure that `@ember/string` has been added
29+
to your project, and even if you still see this deprecation warning on `v4.x`, imports from
30+
`@ember/string` will continue to work and no longer display a deprecation warning
31+
once on `v5.x`.

0 commit comments

Comments
 (0)