Skip to content

Commit 5faee08

Browse files
authored
Merge branch 'main' into ember-data-v5-deprecations
2 parents 8c0a25c + 31182f2 commit 5faee08

File tree

5 files changed

+71
-0
lines changed

5 files changed

+71
-0
lines changed

app/templates/index.hbs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,12 @@
6969
@models={{array 'ember-cli' 'v4.x'}}
7070
>v4.x</LinkTo>
7171
</li>
72+
<li class='list-unstyled' data-test-ember-cli-5-link>
73+
<LinkTo
74+
@route='show'
75+
@models={{array 'ember-cli' 'v5.x'}}
76+
>v5.x</LinkTo>
77+
</li>
7278
</ul>
7379
</li>
7480
<li class='item list-unstyled'>
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
---
2+
title: outputPaths build option
3+
until: 6.0.0
4+
since: 5.3.0
5+
displayId: ember-cli.outputPaths-build-option
6+
---
7+
8+
9+
Using the `outputPaths` build option is deprecated, as output paths will no longer be predetermined under Embroider.
10+
11+
To resolve the deprecation, please remove the `outputPaths` build option from your `ember-cli-build.js` file:
12+
13+
```diff
14+
module.exports = function (defaults) {
15+
const app = new EmberApp(defaults, {
16+
- outputPaths: {
17+
- app: {
18+
- js: `/assets/foo.js`,
19+
- },
20+
- },
21+
};
22+
};
23+
```
24+
25+
And update your `app/index.html` file accordingly:
26+
27+
```diff
28+
<!DOCTYPE html>
29+
<html>
30+
<head>
31+
<meta charset="utf-8">
32+
<title>MyAppName</title>
33+
<meta name="description" content="">
34+
<meta name="viewport" content="width=device-width, initial-scale=1">
35+
36+
{{content-for "head"}}
37+
38+
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
39+
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/my-app-name.css">
40+
41+
{{content-for "head-footer"}}
42+
</head>
43+
<body>
44+
{{content-for "body"}}
45+
46+
<script src="{{rootURL}}assets/vendor.js"></script>
47+
- <script src="{{rootURL}}assets/foo.js"></script>
48+
+ <script src="{{rootURL}}assets/my-app-name.js"></script>
49+
50+
{{content-for "body-footer"}}
51+
</body>
52+
</html>
53+
```

ember-cli-build.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ module.exports = function (defaults) {
3636
'/ember-data/v5.x',
3737
'/ember-cli/v2.x',
3838
'/ember-cli/v4.x',
39+
'/ember-cli/v5.x',
3940
...getDeprecationFilenames(),
4041
],
4142
},

lib/content-docs-generator/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const contentFolders = [
1717
'ember-data/v5',
1818
'ember-cli/v2',
1919
'ember-cli/v4',
20+
'ember-cli/v5',
2021
];
2122

2223
const jsonTrees = contentFolders.map(

tests/acceptance/visual-regression-test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,16 @@ module('Acceptance | visual regression', function (hooks) {
9090

9191
await percySnapshot('ember-cli-4.x');
9292

93+
// v5.x Ember CLI
94+
await click('[data-test-main-deprecations-link]');
95+
await click('[data-test-ember-cli-5-link] > a');
96+
97+
assert
98+
.dom('[data-test-deprecations-added-in]')
99+
.hasText('Deprecations Added in Ember CLI 5.x');
100+
101+
await percySnapshot('ember-cli-5.x');
102+
93103
// v5.x Ember
94104
await click('[data-test-main-deprecations-link]');
95105
await click('[data-test-ember-5-link] > a');

0 commit comments

Comments
 (0)