Array json (#221)

* Allow JSON arrays

Author: ConnorRigby

CHANGELOG.md

@@ -1,4 +1,10 @@
 # Changelog for v2.2.x Series
+## v2.3.0
+
+_17 October 2018_
+
+* Allow {:array, :map} via JSON library.
+* Update error messages for clarity.
 
 ## v2.2.3
 

lib/sqlite_db_connection/protocol.ex

@@ -165,6 +165,7 @@ defmodule Sqlite.DbConnection.Protocol do
                                           num_rows: num_rows,
                                           columns: atoms_to_strings(column_names),
                                           command: command}}
+      {:error, :wrong_type} -> {:error, %ArgumentError{message: "Wrong type"}, s}
       {:error, {_sqlite_errcode, _message}} = err ->
         sqlite_error(err, s)
       {:error, %Sqlite.DbConnection.Error{} = err} ->
@@ -218,8 +219,8 @@ defmodule Sqlite.DbConnection.Protocol do
     catch
       :exit, {:timeout, _gen_server_call} ->
         {:error, %Sqlite.DbConnection.Error{message: "Timeout"}}
-      :exit, _ex ->
-        {:error, %Sqlite.DbConnection.Error{message: "Disconnected"}}
+      :exit, ex ->
+        {:error, %Sqlite.DbConnection.Error{message: inspect(ex)}}
     end
   end
 end

lib/sqlite_ecto/connection.ex

@@ -66,6 +66,8 @@ if Code.ensure_loaded?(Sqlitex.Server) do
           value
         %{} = value ->
           Ecto.Adapter.json_library().encode!(value)
+        value when is_list(value) ->
+          Ecto.Adapter.json_library().encode!(value)
         value ->
           value
       end
@@ -496,7 +498,7 @@ if Code.ensure_loaded?(Sqlitex.Server) do
       [@pseudo_returning_statement, cmd, ?\s, fields]
     end
 
-    defp ecto_to_db({:array, _}) do
+    defp ecto_to_db({:array, _data}) do
       raise ArgumentError, "Array type is not supported by SQLite"
     end
 
@@ -772,7 +774,7 @@ if Code.ensure_loaded?(Sqlitex.Server) do
     defp column_type(:string, _opts), do: "TEXT"
     defp column_type(:map, _opts), do: "TEXT"
     defp column_type({:map, _}, _opts), do: "TEXT"
-    defp column_type({:array, _}, _opts), do: raise(ArgumentError, "Array type is not supported by SQLite")
+    defp column_type({:array, _}, _opts), do: "TEXT"
     defp column_type(:decimal, opts) do
       # We only store precision and scale for DECIMAL.
       precision = Keyword.get(opts, :precision)

mix.exs

@@ -3,7 +3,7 @@ defmodule Sqlite.Ecto2.Mixfile do
 
   def project do
     [app: :sqlite_ecto2,
-     version: "2.2.5",
+     version: "2.3.0",
      name: "Sqlite.Ecto2",
      elixir: "~> 1.4",
      deps: deps(),

test/sqlite_ecto_test.exs

@@ -864,9 +864,9 @@ defmodule Sqlite.Ecto2.Test do
     create = {:create, table(:posts),
                [{:add, :name, {:array, :numeric}, []}]}
 
-    assert_raise ArgumentError, ~r"Array type is not supported by SQLite", fn ->
-      execute_ddl(create)
-    end
+    assert execute_ddl(create) == ["""
+    CREATE TABLE "posts" ("name" TEXT)
+    """ |> remove_newlines()]
   end
 
   test "create table illegal options" do