Use elixir 1.15 :root in formatter_for (#890)

* add a project_dir option to formatter_for, with root

* use -dev

Author: DianaOlympos

apps/language_server/lib/language_server/experimental/code_mod/format.ex

@@ -27,7 +27,7 @@ defmodule ElixirLS.LanguageServer.Experimental.CodeMod.Format do
     project_path = Conversions.ensure_path(project_path_or_uri)
 
     with :ok <- check_current_directory(document, project_path),
-         {:ok, formatter, options} <- formatter_for(document.path),
+         {:ok, formatter, options} <- formatter_for(document.path, project_path),
          :ok <-
            check_inputs_apply(document, project_path, Keyword.get(options, :inputs)) do
       document
@@ -44,15 +44,21 @@ defmodule ElixirLS.LanguageServer.Experimental.CodeMod.Format do
     |> formatter.()
   end
 
-  @spec formatter_for(String.t()) ::
+  @spec formatter_for(String.t(), String.t() | nil) ::
           {:ok, formatter_function, keyword()} | {:error, :no_formatter_available}
-  defp formatter_for(uri_or_path) do
+  defp formatter_for(uri_or_path, project_dir) do
     path = Conversions.ensure_path(uri_or_path)
 
     try do
       true = Code.ensure_loaded?(Mix.Tasks.Format)
 
-      if function_exported?(Mix.Tasks.Format, :formatter_for_file, 1) do
+      if project_dir && Version.match?(System.version(), ">= 1.15.0-dev") do
+        {formatter_function, options} = Mix.Tasks.Format.formatter_for_file(path, root: project_dir)
+
+        wrapped_formatter_function = wrap_with_try_catch(formatter_function)
+
+        {:ok, wrapped_formatter_function, options}
+      else if Version.match?(System.version(), ">= 1.13.0") do
         {formatter_function, options} = Mix.Tasks.Format.formatter_for_file(path)
 
         wrapped_formatter_function = wrap_with_try_catch(formatter_function)
@@ -63,6 +69,7 @@ defmodule ElixirLS.LanguageServer.Experimental.CodeMod.Format do
         formatter = build_formatter(options)
         {:ok, formatter, Mix.Tasks.Format.formatter_opts_for_file(path)}
       end
+    end
     rescue
       e ->
         message = Exception.message(e)

apps/language_server/lib/language_server/providers/execute_command/apply_spec.ex

@@ -56,7 +56,7 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.ApplySpec do
     formatted =
       try do
         target_line_length =
-          case SourceFile.formatter_for(uri) do
+          case SourceFile.formatter_for(uri, state.project_dir) do
             {:ok, {_, opts}} -> Keyword.get(opts, :line_length, @default_target_line_length)
             :error -> @default_target_line_length
           end

apps/language_server/lib/language_server/providers/formatting.ex

@@ -6,7 +6,7 @@ defmodule ElixirLS.LanguageServer.Providers.Formatting do
   def format(%SourceFile{} = source_file, uri = "file:" <> _, project_dir)
       when is_binary(project_dir) do
     if can_format?(uri, project_dir) do
-      case SourceFile.formatter_for(uri) do
+      case SourceFile.formatter_for(uri, project_dir) do
         {:ok, {formatter, opts}} ->
           if should_format?(uri, project_dir, opts[:inputs]) do
             do_format(source_file, formatter, opts)

apps/language_server/lib/language_server/server.ex

@@ -706,7 +706,7 @@ defmodule ElixirLS.LanguageServer.Server do
       !!get_in(state.client_capabilities, ["textDocument", "signatureHelp"])
 
     locals_without_parens =
-      case SourceFile.formatter_for(uri) do
+      case SourceFile.formatter_for(uri, state.project_dir) do
         {:ok, {_, opts}} -> Keyword.get(opts, :locals_without_parens, [])
         :error -> []
       end

apps/language_server/lib/language_server/source_file.ex

@@ -232,18 +232,21 @@ defmodule ElixirLS.LanguageServer.SourceFile do
     """
   end
 
-  @spec formatter_for(String.t()) :: {:ok, {function | nil, keyword()}} | :error
-  def formatter_for(uri = "file:" <> _) do
+  @spec formatter_for(String.t(), String.t() | nil) :: {:ok, {function | nil, keyword()}} | :error
+  def formatter_for(uri = "file:" <> _, project_dir) do
     path = __MODULE__.Path.from_uri(uri)
 
     try do
       true = Code.ensure_loaded?(Mix.Tasks.Format)
 
-      if Version.match?(System.version(), ">= 1.13.0") do
+      if project_dir && Version.match?(System.version(), ">= 1.15.0-dev") do
+        {:ok, apply(Mix.Tasks.Format, :formatter_for_file, [path, {:root, project_dir }])}
+      else if Version.match?(System.version(), ">= 1.13.0") do
         {:ok, apply(Mix.Tasks.Format, :formatter_for_file, [path])}
       else
         {:ok, {nil, apply(Mix.Tasks.Format, :formatter_opts_for_file, [path])}}
       end
+    end
     rescue
       e ->
         message = Exception.message(e)

apps/language_server/test/source_file/invalid_project_test.exs

@@ -26,7 +26,7 @@ defmodule ElixirLS.LanguageServer.SourceFile.InvalidProjectTest do
 
       output =
         capture_log(fn ->
-          assert :error = SourceFile.formatter_for("file:///root.ex")
+          assert :error = SourceFile.formatter_for("file:///root.ex", "")
         end)
 
       assert String.contains?(output, "Unable to get formatter options")
@@ -39,7 +39,7 @@ defmodule ElixirLS.LanguageServer.SourceFile.InvalidProjectTest do
 
       output =
         capture_log(fn ->
-          assert :error = SourceFile.formatter_for("file:///root.ex")
+          assert :error = SourceFile.formatter_for("file:///root.ex", "")
         end)
 
       assert String.contains?(output, "Unable to get formatter options")