fix: check if custom nsis and/or nsis resources paths is not purely an whitespace string (#9420)

Author: mmaietta

.changeset/tricky-tables-open.md

@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: check if custom nsis and/or nsis resources paths is not purely white space

packages/app-builder-lib/src/targets/nsis/nsisUtil.ts

@@ -1,4 +1,4 @@
-import { Arch, copyFile, dirSize, log } from "builder-util"
+import { Arch, copyFile, dirSize, isEmptyOrSpaces, log } from "builder-util"
 import { PackageFileInfo } from "builder-util-runtime"
 import * as fs from "fs/promises"
 import * as path from "path"
@@ -20,10 +20,10 @@ export const NsisTargetOptions = (() => {
 })()
 
 export const NSIS_PATH = () => {
-  const custom = process.env.ELECTRON_BUILDER_NSIS_DIR
-  if (custom != null && custom.length > 0) {
-    log.info({ path: custom.trim() }, "using local nsis")
-    return Promise.resolve(custom.trim())
+  const custom = process.env.ELECTRON_BUILDER_NSIS_DIR?.trim()
+  if (!isEmptyOrSpaces(custom)) {
+    log.info({ path: custom }, "using local nsis")
+    return Promise.resolve(custom)
   }
   return NsisTargetOptions.then((options: NsisOptions) => {
     if (options.customNsisBinary) {
@@ -39,10 +39,10 @@ export const NSIS_PATH = () => {
 }
 
 export const NSIS_RESOURCES_PATH = () => {
-  const custom = process.env.ELECTRON_BUILDER_NSIS_RESOURCES_DIR
-  if (custom != null && custom.length > 0) {
-    log.info({ path: custom.trim() }, "using local nsis-resources")
-    return Promise.resolve(custom.trim())
+  const custom = process.env.ELECTRON_BUILDER_NSIS_RESOURCES_DIR?.trim()
+  if (!isEmptyOrSpaces(custom)) {
+    log.info({ path: custom }, "using local nsis-resources")
+    return Promise.resolve(custom)
   }
   return NsisTargetOptions.then((options: NsisOptions) => {
     if (options.customNsisResources) {