From 1640274639340507e281bf0dae8a814a89bb3e32 Mon Sep 17 00:00:00 2001 From: myronsonos <53064504+myronsonos@users.noreply.github.com> Date: Thu, 24 Feb 2022 19:41:46 -0800 Subject: [PATCH 1/2] The request.status_code line is only valid if request is not null. The request.status_code line is only valid if request is not null, this line belongs in the for loop where request can potentially have meaning when it is not None but has a failing status code. --- dlipower/dlipower.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlipower/dlipower.py b/dlipower/dlipower.py index 835efdf..559cc11 100755 --- a/dlipower/dlipower.py +++ b/dlipower/dlipower.py @@ -426,7 +426,7 @@ def geturl(self, url='index.htm'): if request.status_code == 200: result = request.content break - logger.debug('Response code: %s', request.status_code) + logger.debug('Response code: %s', request.status_code) logger.debug(f'Response content: {result}') return result From 8f5accff2edfb07f88d1d7d3d9bf68b6a67311e6 Mon Sep 17 00:00:00 2001 From: myronsonos <53064504+myronsonos@users.noreply.github.com> Date: Thu, 24 Feb 2022 19:43:37 -0800 Subject: [PATCH 2/2] Move to out of loop but inside of an if check Move to out of loop but inside of an if check so we don't log too much. --- dlipower/dlipower.py | 1 + 1 file changed, 1 insertion(+) diff --git a/dlipower/dlipower.py b/dlipower/dlipower.py index 559cc11..b8bfb6b 100755 --- a/dlipower/dlipower.py +++ b/dlipower/dlipower.py @@ -426,6 +426,7 @@ def geturl(self, url='index.htm'): if request.status_code == 200: result = request.content break + if request is not None: logger.debug('Response code: %s', request.status_code) logger.debug(f'Response content: {result}') return result