From b1f137cc556922ef3fc25b3732a18fbb3a2704ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=B7=9F=E7=9D=80=E5=93=86=E5=95=A6=E5=AD=A6=E5=AE=89?=
 =?UTF-8?q?=E5=8D=93?= <71242257+dora4@users.noreply.github.com>
Date: Tue, 19 Aug 2025 05:33:46 +0800
Subject: [PATCH] test: cover UrlEncoderUtils hasUrlEncoded

---
 .../java/dora/http/log/UrlEncoderUtils.kt     |  2 --
 .../java/dora/http/log/UrlEncoderUtilsTest.kt | 19 +++++++++++++++++++
 2 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 dcache/src/test/java/dora/http/log/UrlEncoderUtilsTest.kt

diff --git a/dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt b/dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt
index c7a9131..308dc2c 100755
--- a/dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt
+++ b/dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt
@@ -28,8 +28,6 @@ class UrlEncoderUtils private constructor() {
                     if (isValidHexChar(c1) && isValidHexChar(c2)) {
                         encode = true
                         break
-                    } else {
-                        break
                     }
                 }
             }
diff --git a/dcache/src/test/java/dora/http/log/UrlEncoderUtilsTest.kt b/dcache/src/test/java/dora/http/log/UrlEncoderUtilsTest.kt
new file mode 100644
index 0000000..c01a838
--- /dev/null
+++ b/dcache/src/test/java/dora/http/log/UrlEncoderUtilsTest.kt
@@ -0,0 +1,19 @@
+package dora.http.log
+
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
+import org.junit.Test
+
+class UrlEncoderUtilsTest {
+
+    @Test
+    fun hasUrlEncoded_detectsValidSequences() {
+        assertTrue(UrlEncoderUtils.hasUrlEncoded("abc%20def"))
+    }
+
+    @Test
+    fun hasUrlEncoded_ignoresInvalidSequences() {
+        assertTrue(UrlEncoderUtils.hasUrlEncoded("abc%2G%20def"))
+        assertFalse(UrlEncoderUtils.hasUrlEncoded("abc%2Gdef"))
+    }
+}