Renamed columnDefinitiontoSchema to tableSpecToSchema

zachmu · zachmu · commit 808d3ef879c4 · 2019-10-17T11:32:48.000-07:00
Signed-off-by: Zach Musgrave &lt;zach@liquidata.co&gt;
diff --git a/sql/parse/parse.go b/sql/parse/parse.go
@@ -389,7 +389,7 @@ func convertDropTable(c *sqlparser.DDL) (sql.Node, error) {
 }
 
 func convertCreateTable(c *sqlparser.DDL) (sql.Node, error) {
-	schema, err := columnDefinitionToSchema(c.TableSpec)
+	schema, err := tableSpecToSchema(c.TableSpec)
 	if err != nil {
 		return nil, err
 	}
@@ -504,7 +504,7 @@ func convertUpdate(ctx *sql.Context, d *sqlparser.Update) (sql.Node, error) {
 	return plan.NewUpdate(node, updateExprs), nil
 }
 
-func columnDefinitionToSchema(tableSpec *sqlparser.TableSpec) (sql.Schema, error) {
+func tableSpecToSchema(tableSpec *sqlparser.TableSpec) (sql.Schema, error) {
 	var schema sql.Schema
 	for _, cd := range tableSpec.Columns {
 		column, err := getColumn(cd, tableSpec.Indexes)

Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,7 @@ func convertDropTable(c *sqlparser.DDL) (sql.Node, error) {`
`389`	`389`	`}`
`390`	`390`
`391`	`391`	`func convertCreateTable(c *sqlparser.DDL) (sql.Node, error) {`
`392`		`- schema, err := columnDefinitionToSchema(c.TableSpec)`
	`392`	`+ schema, err := tableSpecToSchema(c.TableSpec)`
`393`	`393`	`if err != nil {`
`394`	`394`	`return nil, err`
`395`	`395`	`}`
`@@ -504,7 +504,7 @@ func convertUpdate(ctx sql.Context, d sqlparser.Update) (sql.Node, error) {`
`504`	`504`	`return plan.NewUpdate(node, updateExprs), nil`
`505`	`505`	`}`
`506`	`506`
`507`		`-func columnDefinitionToSchema(tableSpec *sqlparser.TableSpec) (sql.Schema, error) {`
	`507`	`+func tableSpecToSchema(tableSpec *sqlparser.TableSpec) (sql.Schema, error) {`
`508`	`508`	`var schema sql.Schema`
`509`	`509`	`for _, cd := range tableSpec.Columns {`
`510`	`510`	`column, err := getColumn(cd, tableSpec.Indexes)`