Skip to content

Commit 4323333

Browse files
committed
Reproduced bug in simple cross join triggered by index lookups
Signed-off-by: Zach Musgrave <zach@liquidata.co>
1 parent 8fe1bb6 commit 4323333

File tree

1 file changed

+24
-4
lines changed

1 file changed

+24
-4
lines changed

engine_test.go

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1644,16 +1644,16 @@ func TestQueries(t *testing.T) {
16441644
// 3) Parallelism on / off
16451645
numPartitionsVals := []int{
16461646
1,
1647-
// testNumPartitions,
1647+
testNumPartitions,
16481648
}
16491649
indexDrivers := []*indexDriverTestCase{
16501650
nil,
1651-
// {"unmergableIndexes", unmergableIndexDriver},
1652-
// {"mergableIndexes", mergableIndexDriver},
1651+
{"unmergableIndexes", unmergableIndexDriver},
1652+
{"mergableIndexes", mergableIndexDriver},
16531653
}
16541654
parallelVals := []int{
16551655
1,
1656-
// 2,
1656+
2,
16571657
}
16581658
for _, numPartitions := range numPartitionsVals {
16591659
for _, indexDriverInit := range indexDrivers {
@@ -1741,6 +1741,16 @@ func unmergableIndexDriver(tables map[string]*memory.Table) sql.IndexDriver {
17411741
newUnmergableIndex(tables, "niltable",
17421742
expression.NewGetFieldWithTable(0, sql.Int64, "niltable", "i", false)),
17431743
},
1744+
"one_pk": {
1745+
newUnmergableIndex(tables, "one_pk",
1746+
expression.NewGetFieldWithTable(0, sql.Int8, "one_pk", "pk", false)),
1747+
},
1748+
"two_pk": {
1749+
newUnmergableIndex(tables, "two_pk",
1750+
expression.NewGetFieldWithTable(0, sql.Int8, "two_pk", "pk1", false),
1751+
expression.NewGetFieldWithTable(1, sql.Int8, "two_pk", "pk2", false),
1752+
),
1753+
},
17441754
})
17451755
}
17461756

@@ -1776,6 +1786,16 @@ func mergableIndexDriver(tables map[string]*memory.Table) sql.IndexDriver {
17761786
newMergableIndex(tables, "niltable",
17771787
expression.NewGetFieldWithTable(0, sql.Int64, "niltable", "i", false)),
17781788
},
1789+
"one_pk": {
1790+
newMergableIndex(tables, "one_pk",
1791+
expression.NewGetFieldWithTable(0, sql.Int8, "one_pk", "pk", false)),
1792+
},
1793+
"two_pk": {
1794+
newMergableIndex(tables, "two_pk",
1795+
expression.NewGetFieldWithTable(0, sql.Int8, "two_pk", "pk1", false),
1796+
expression.NewGetFieldWithTable(1, sql.Int8, "two_pk", "pk2", false),
1797+
),
1798+
},
17791799
})
17801800
}
17811801

0 commit comments

Comments
 (0)