delay random seconds after connection failed

Author: doghappy

src/SocketIOClient/V2/DefaultRandom.cs

@@ -0,0 +1,18 @@
+using System;
+
+namespace SocketIOClient.V2;
+
+public interface IRandom
+{
+    int Next(int max);
+}
+
+public class DefaultRandom : IRandom
+{
+    private readonly Random _random = new();
+
+    public int Next(int max)
+    {
+        return _random.Next(max);
+    }
+}

src/SocketIOClient/V2/DefaultSessionFactory.cs

@@ -8,6 +8,11 @@
 
 namespace SocketIOClient.V2;
 
+public interface ISessionFactory
+{
+    ISession New(EngineIO eio);
+}
+
 public class DefaultSessionFactory : ISessionFactory
 {
     public ISession New(EngineIO eio)

src/SocketIOClient/V2/ISessionFactory.cs

@@ -21,6 +21,7 @@ public SocketIO(Uri uri, SocketIOOptions options)
         _serverUri = uri;
         Options = options;
         SessionFactory = new DefaultSessionFactory();
+        Random = new DefaultRandom();
     }
 
     public SocketIO(Uri uri) : this(uri, new SocketIOOptions())
@@ -37,6 +38,7 @@ public SocketIO(Uri uri, SocketIOOptions options)
     public int PacketId { get; private set; }
     public bool Connected { get; private set; }
     public string Id { get; private set; }
+    public IRandom Random { get; set; }
 
     public string Namespace { get; private set; }
 
@@ -92,6 +94,8 @@ public async Task ConnectAsync(CancellationToken cancellationToken)
                 {
                     throw ex;
                 }
+                var delay = Random.Next(Options.ReconnectionDelayMax);
+                await Task.Delay(delay, CancellationToken.None);
             }
         }
     }

src/SocketIOClient/V2/SocketIO.cs

@@ -6,6 +6,7 @@ public class SocketIOOptions
 {
     public EngineIO EIO { get; set; }
     public TimeSpan ConnectionTimeout { get; set; }
-    public bool Reconnection { get; set; }
-    public int ReconnectionAttempts { get; set; }
+    public bool Reconnection { get; set; } = true;
+    public int ReconnectionAttempts { get; set; } = int.MaxValue;
+    public int ReconnectionDelayMax { get; set; } = 5000;
 }

src/SocketIOClient/V2/SocketIOOptions.cs

@@ -15,14 +15,21 @@ public SocketIOTests()
         _session = Substitute.For<ISession>();
         var sessionFactory = Substitute.For<ISessionFactory>();
         sessionFactory.New(Arg.Any<EngineIO>()).Returns(_session);
+        _random = Substitute.For<IRandom>();
         _io = new SocketIOClient.V2.SocketIO("http://localhost:3000")
         {
             SessionFactory = sessionFactory,
+            Random = _random,
+            Options =
+            {
+                Reconnection = false,
+            },
         };
     }
 
     private readonly SocketIOClient.V2.SocketIO _io;
     private readonly ISession _session;
+    private readonly IRandom _random;
 
     [Fact]
     public void NothingCalled_DefaultValues()
@@ -141,6 +148,23 @@ await _io
             .ThrowAsync<OperationCanceledException>();
     }
 
+    [Fact]
+    public async Task ConnectAsyncCancellationToken_CancelAfter200ms_ThrowConnectionException()
+    {
+        _io.Options.Reconnection = true;
+        _random.Next(Arg.Any<int>()).Returns(10);
+
+        await _io
+            .Invoking(async x =>
+            {
+                using var cts = new CancellationTokenSource();
+                cts.CancelAfter(TimeSpan.FromMilliseconds(100));
+                await x.ConnectAsync(cts.Token);
+            })
+            .Should()
+            .ThrowAsync<OperationCanceledException>();
+    }
+
     [Fact]
     public async Task EmitAsync_AckEventAction_PacketIdIncrementBy1()
     {