Skip to content

Commit a455fa7

Browse files
committed
feat: remove the legacy copyTo contracts from n2c images
These don't work with the multitags and are a concatenation of build & metadata in the same implementation. The multitag feature surfaced these shortcomings and hence we should remove these facilities to avoid people using (and cementing usage of) a non-public api because of habit.
1 parent d2427de commit a455fa7

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

cells/lib/ops/mkOCI.nix

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,5 +92,12 @@ in
9292
// l.throwIf (args ? tag && meta ? tags)
9393
"mkOCI: use of `tag` and `meta.tags` arguments are not supported together. Remove the former."
9494
(l.optionalAttrs (tag != "") {inherit tag;});
95+
96+
image = n2c.buildImage (l.recursiveUpdate options options');
9597
in
96-
n2c.buildImage (l.recursiveUpdate options options')
98+
l.removeAttrs image [
99+
"copyTo"
100+
"copyToDockerDaemon"
101+
"copyToPodman"
102+
"copyToRegistry"
103+
]

0 commit comments

Comments
 (0)