From 46aeaefaedb91d8311bb8df7638801f004dd7ea1 Mon Sep 17 00:00:00 2001 From: "David I. Lehn" Date: Wed, 3 Dec 2025 18:12:37 -0500 Subject: [PATCH 1/5] Use .yaml. --- .github/workflows/{main.yml => main.yaml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{main.yml => main.yaml} (100%) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yaml similarity index 100% rename from .github/workflows/main.yml rename to .github/workflows/main.yaml From 1a521dbd72d1983fc5227bd6dc32d6ffcc58702a Mon Sep 17 00:00:00 2001 From: "David I. Lehn" Date: Wed, 3 Dec 2025 18:12:47 -0500 Subject: [PATCH 2/5] Update badges. --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 06cff04c9..bbf7fdc61 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ # Forge -[![npm package](https://nodei.co/npm/node-forge.png?downloads=true&downloadRank=true&stars=true)](https://nodei.co/npm/node-forge/) +[![NPM](https://nodei.co/npm/node-forge.svg?data=d)](https://nodei.co/npm/node-forge/) -[![Build Status](https://github.com/digitalbazaar/forge/workflows/Main%20Checks/badge.svg)](https://github.com/digitalbazaar/forge/actions?query=workflow%3A%22Main+Checks%22) +[![Main Checks](https://github.com/digitalbazaar/forge/actions/workflows/main.yaml/badge.svg)](https://github.com/digitalbazaar/forge/actions/workflows/main.yaml) A native implementation of [TLS][] (and various other cryptographic tools) in [JavaScript][]. From fcccde68057681fe71948f3f5a9280606319e03c Mon Sep 17 00:00:00 2001 From: "David I. Lehn" Date: Wed, 3 Dec 2025 18:17:11 -0500 Subject: [PATCH 3/5] Run jobs for PRs. --- .github/workflows/main.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 77be5fef2..c5615dee5 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -1,6 +1,12 @@ name: Main Checks -on: [push] +on: + push: + branches: + - 'main' + pull_request: + branches: + - '**' jobs: test-node: From 6541d8188a1175115bcec44c775a57b4605ea87b Mon Sep 17 00:00:00 2001 From: "David I. Lehn" Date: Wed, 3 Dec 2025 18:18:22 -0500 Subject: [PATCH 4/5] Fix issues from zizmor. --- .github/workflows/main.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index c5615dee5..8e5aba5b2 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -8,6 +8,8 @@ on: branches: - '**' +permissions: {} + jobs: test-node: runs-on: ubuntu-latest @@ -17,6 +19,8 @@ jobs: node-version: [6.x, 8.x, 10.x, 12.x, 14.x, 16.x, 18.x, 20.x, 22.x, 24.x] steps: - uses: actions/checkout@v4 + with: + persist-credentials: false # FIXME: Install/build with 16.x until webpack is updated - name: Use Node.js 16.x uses: actions/setup-node@v4 @@ -39,6 +43,8 @@ jobs: bundler: [webpack, browserify] steps: - uses: actions/checkout@v4 + with: + persist-credentials: false - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 with: @@ -56,6 +62,8 @@ jobs: # node-version: [16.x] # steps: # - uses: actions/checkout@v4 +# with: +# persist-credentials: false # - name: Use Node.js ${{ matrix.node-version }} # uses: actions/setup-node@v4 # with: @@ -71,6 +79,8 @@ jobs: node-version: [16.x] steps: - uses: actions/checkout@v4 + with: + persist-credentials: false - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 with: From d052eb7f6720c00c0cb321d1eef5e4bb592770fe Mon Sep 17 00:00:00 2001 From: "David I. Lehn" Date: Wed, 3 Dec 2025 18:30:05 -0500 Subject: [PATCH 5/5] Update action versions. --- .github/workflows/main.yaml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 8e5aba5b2..8c810588f 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -18,18 +18,18 @@ jobs: matrix: node-version: [6.x, 8.x, 10.x, 12.x, 14.x, 16.x, 18.x, 20.x, 22.x, 24.x] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 with: persist-credentials: false # FIXME: Install/build with 16.x until webpack is updated - name: Use Node.js 16.x - uses: actions/setup-node@v4 + uses: actions/setup-node@v6 with: node-version: 16.x - run: npm install # FIXME: Run tests with target version until webpack is updated - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 + uses: actions/setup-node@v6 with: node-version: ${{ matrix.node-version }} - name: Run test with Node.js ${{ matrix.node-version }} @@ -42,11 +42,11 @@ jobs: node-version: [16.x] bundler: [webpack, browserify] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 with: persist-credentials: false - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 + uses: actions/setup-node@v6 with: node-version: ${{ matrix.node-version }} - run: npm install @@ -61,11 +61,11 @@ jobs: # matrix: # node-version: [16.x] # steps: -# - uses: actions/checkout@v4 +# - uses: actions/checkout@v5 # with: # persist-credentials: false # - name: Use Node.js ${{ matrix.node-version }} -# uses: actions/setup-node@v4 +# uses: actions/setup-node@v6 # with: # node-version: ${{ matrix.node-version }} # - run: npm install @@ -78,19 +78,19 @@ jobs: matrix: node-version: [16.x] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 with: persist-credentials: false - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 + uses: actions/setup-node@v6 with: node-version: ${{ matrix.node-version }} - run: npm install - name: Generate coverage report run: npm run coverage-ci - name: Upload coverage to Codecov - uses: codecov/codecov-action@v4 + uses: codecov/codecov-action@v5 with: - file: ./coverage/lcov.info + files: ./coverage/lcov.info fail_ci_if_error: true token: ${{ secrets.CODECOV_TOKEN }}