From 3481b54438af7ed1bd87a7c6016d4d62a6d9c4ed Mon Sep 17 00:00:00 2001
From: Rajvi Patel <rajvi2232000@gmail.com>
Date: Fri, 10 Oct 2025 15:34:51 -0700
Subject: [PATCH 1/2] [CITE-241] Remove clickable links for failed file uploads

---
 .../src/main/webapp/WEB-INF/views/auth/group/item.html       | 5 ++++-
 .../main/webapp/WEB-INF/views/auth/group/itemVersion.html    | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html b/citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html
index f6779dbcb..8f941c66d 100644
--- a/citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html
+++ b/citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html
@@ -535,9 +535,12 @@ <h3 style="margin-top: 0">Files</h3>
         <ul class="list-group" >
 	        <li class="list-group-item" th:each="upload:${citation.gilesUploads}">
 	        <i class="icon-giles"></i>
-	        <span th:if="${upload.uploadedFile?.filename}">
+	        <span th:if="${upload.uploadedFile?.filename && upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
 	        <a th:href="@{|/auth/group/${zoteroGroupId}/items/${citation.key}/giles/${upload.uploadedFile?.id}|}">[[${upload.uploadedFile?.filename}]]</a>
 	        </span>
+	        <span th:if="${upload.uploadedFile?.filename && upload.documentStatus == T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
+	        [[${upload.uploadedFile?.filename}]]
+	        </span>
 	        <span th:unless="${upload.documentStatus != null && (upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).SUBMITTED || T(edu.asu.diging.citesphere.model.bib.GilesStatus).NEW)}">
 	        File is being processed... ([[${upload.progressId}]])
 	        </span>
diff --git a/citesphere/src/main/webapp/WEB-INF/views/auth/group/itemVersion.html b/citesphere/src/main/webapp/WEB-INF/views/auth/group/itemVersion.html
index 4f692a286..35c6c4ddf 100644
--- a/citesphere/src/main/webapp/WEB-INF/views/auth/group/itemVersion.html
+++ b/citesphere/src/main/webapp/WEB-INF/views/auth/group/itemVersion.html
@@ -250,9 +250,12 @@ <h3 style="margin-top: 0">Files</h3>
         <ul class="list-group" >
             <li class="list-group-item" th:each="upload:${citation.gilesUploads}">
                 <i class="icon-giles"></i>
-                <span th:if="${upload.uploadedFile?.filename}">
+                <span th:if="${upload.uploadedFile?.filename && upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
                 <a th:href="@{|/auth/group/${zoteroGroupId}/items/${citation.key}/giles/${upload.uploadedFile?.id}|}">[[${upload.uploadedFile?.filename}]]</a>
                 </span>
+                <span th:if="${upload.uploadedFile?.filename && upload.documentStatus == T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
+                [[${upload.uploadedFile?.filename}]]
+                </span>
                 <span th:unless="${upload.documentStatus != null && (upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).SUBMITTED || T(edu.asu.diging.citesphere.model.bib.GilesStatus).NEW)}">
                 File is being processed... ([[${upload.progressId}]])
                 </span>

From 75571331c412200aae296cc235b2470b24d15a42 Mon Sep 17 00:00:00 2001
From: Rajvi Patel <rajvi2232000@gmail.com>
Date: Mon, 13 Oct 2025 16:35:11 -0700
Subject: [PATCH 2/2] [CITE-241] Fix item template for failed uploads

---
 citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html | 4 ++--
 .../src/main/webapp/WEB-INF/views/auth/group/itemVersion.html | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html b/citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html
index 8f941c66d..64e897b7a 100644
--- a/citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html
+++ b/citesphere/src/main/webapp/WEB-INF/views/auth/group/item.html
@@ -535,10 +535,10 @@ <h3 style="margin-top: 0">Files</h3>
         <ul class="list-group" >
 	        <li class="list-group-item" th:each="upload:${citation.gilesUploads}">
 	        <i class="icon-giles"></i>
-	        <span th:if="${upload.uploadedFile?.filename && upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
+	        <span th:if="${upload.uploadedFile?.filename != null and upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
 	        <a th:href="@{|/auth/group/${zoteroGroupId}/items/${citation.key}/giles/${upload.uploadedFile?.id}|}">[[${upload.uploadedFile?.filename}]]</a>
 	        </span>
-	        <span th:if="${upload.uploadedFile?.filename && upload.documentStatus == T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
+	        <span th:if="${upload.uploadedFile?.filename != null and upload.documentStatus == T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
 	        [[${upload.uploadedFile?.filename}]]
 	        </span>
 	        <span th:unless="${upload.documentStatus != null && (upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).SUBMITTED || T(edu.asu.diging.citesphere.model.bib.GilesStatus).NEW)}">
diff --git a/citesphere/src/main/webapp/WEB-INF/views/auth/group/itemVersion.html b/citesphere/src/main/webapp/WEB-INF/views/auth/group/itemVersion.html
index 35c6c4ddf..f7fe1883d 100644
--- a/citesphere/src/main/webapp/WEB-INF/views/auth/group/itemVersion.html
+++ b/citesphere/src/main/webapp/WEB-INF/views/auth/group/itemVersion.html
@@ -250,10 +250,10 @@ <h3 style="margin-top: 0">Files</h3>
         <ul class="list-group" >
             <li class="list-group-item" th:each="upload:${citation.gilesUploads}">
                 <i class="icon-giles"></i>
-                <span th:if="${upload.uploadedFile?.filename && upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
+                <span th:if="${upload.uploadedFile?.filename != null and upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
                 <a th:href="@{|/auth/group/${zoteroGroupId}/items/${citation.key}/giles/${upload.uploadedFile?.id}|}">[[${upload.uploadedFile?.filename}]]</a>
                 </span>
-                <span th:if="${upload.uploadedFile?.filename && upload.documentStatus == T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
+                <span th:if="${upload.uploadedFile?.filename != null and upload.documentStatus == T(edu.asu.diging.citesphere.model.bib.GilesStatus).FAILED}">
                 [[${upload.uploadedFile?.filename}]]
                 </span>
                 <span th:unless="${upload.documentStatus != null && (upload.documentStatus != T(edu.asu.diging.citesphere.model.bib.GilesStatus).SUBMITTED || T(edu.asu.diging.citesphere.model.bib.GilesStatus).NEW)}">