Skip to content

Commit 7334809

Browse files
dependabot[bot]mfranzke
dependabot[bot]
and
mfranzke
authored
chore(deps-dev): bump the stylelint group with 2 updates (#4753)
* chore(deps-dev): bump the stylelint group with 2 updates Bumps the stylelint group with 2 updates: [stylelint-config-recommended-scss](https://github.com/stylelint-scss/stylelint-config-recommended-scss) and [stylelint-config-standard](https://github.com/stylelint/stylelint-config-standard). Updates `stylelint-config-recommended-scss` from 15.0.1 to 16.0.0 - [Release notes](https://github.com/stylelint-scss/stylelint-config-recommended-scss/releases) - [Changelog](https://github.com/stylelint-scss/stylelint-config-recommended-scss/blob/master/CHANGELOG.md) - [Commits](stylelint-scss/stylelint-config-recommended-scss@v15.0.1...v16.0.0) Updates `stylelint-config-standard` from 38.0.0 to 39.0.0 - [Release notes](https://github.com/stylelint/stylelint-config-standard/releases) - [Changelog](https://github.com/stylelint/stylelint-config-standard/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint-config-standard@38.0.0...39.0.0) --- updated-dependencies: - dependency-name: stylelint-config-recommended-scss dependency-version: 16.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: stylelint - dependency-name: stylelint-config-standard dependency-version: 39.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: stylelint ... Signed-off-by: dependabot[bot] <support@github.com> * refactor: not mixing recommended and standard * docs: added stylelint config differences * refactor: stylinelint auto-fixes * chore(markdownlint): fix findings * refactor: stylelint feedback * refactor: import-notation stylelint feedback --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maximilian Franzke <Maximilian.Franzke@deutschebahn.com> Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
1 parent 5c24df2 commit 7334809

File tree

84 files changed

+246
-230
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

84 files changed

+246
-230
lines changed

‎.stylelintrc.json‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
2-
"extends": [
3-
"stylelint-config-standard",
4-
"stylelint-config-recommended-scss"
5-
],
2+
"extends": ["stylelint-config-standard-scss"],
63
"plugins": [
74
"stylelint-use-logical",
85
"@double-great/stylelint-a11y",

‎docs/stylelint-scss-config.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# Differences in between `stylelint-config-standard-scss` and `stylelint-config-recommended-scss`
2+
3+
## Short version
4+
5+
- `stylelint-config-recommended-scss`
6+
- Minimal, “avoid bugs” preset for SCSS.
7+
- Extends the core recommended rules and the SCSS plugin’s recommended rules.
8+
- Turns off core rules that conflict with SCSS syntax.
9+
- Little to no stylistic/opinionated formatting. Fewer warnings; great if you use Prettier.
10+
11+
- `stylelint-config-standard-scss`
12+
- Superset of recommended-scss with opinions.
13+
- Adds many formatting/convention rules (mostly via `stylelint-stylistic`) for quotes, spacing, commas, hex case/length, newline placement, etc.
14+
- Still disables core rules that conflict with SCSS, but enforces a consistent style and will surface more issues (mostly auto-fixable).
15+
16+
## Practical guidance
17+
18+
- Use recommended-scss if you want just correctness checks for SCSS and let Prettier handle formatting.
19+
- Use standard-scss if you want Stylelint to also enforce style conventions across SCSS.
20+
- Either SCSS preset avoids CSS‑Nesting‑only checks on .scss files (the “missing scoping root” issue appears when using non‑SCSS presets like `stylelint-config-standard` on SCSS).

‎package-lock.json‎

Lines changed: 82 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,7 @@
128128
"rimraf": "6.0.1",
129129
"rxjs": "7.8.2",
130130
"stylelint": "16.23.1",
131-
"stylelint-config-recommended-scss": "15.0.1",
132-
"stylelint-config-standard": "38.0.0",
131+
"stylelint-config-standard-scss": "^15.0.1",
133132
"stylelint-use-logical": "2.1.2",
134133
"tslib": "2.8.1",
135134
"tsx": "4.20.4",

‎packages/components/src/components/accordion/accordion.scss‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ The spacings are not part of the styling of the accordion items themselves.
2121

2222
&[data-variant="divider"],
2323
&:not([data-variant]) {
24-
@include accordion-subsequent-item-selector() {
24+
@include accordion-subsequent-item-selector {
2525
// One space each before and after the divider results in a double spacing
2626
margin-block-start: calc(2 * #{variables.$db-spacing-fixed-sm});
2727

@@ -35,7 +35,7 @@ The spacings are not part of the styling of the accordion items themselves.
3535
}
3636

3737
&[data-variant="card"] {
38-
@include accordion-subsequent-item-selector() {
38+
@include accordion-subsequent-item-selector {
3939
margin-block-start: variables.$db-spacing-fixed-sm;
4040
}
4141

‎packages/components/src/components/badge/badge.scss‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
@extend %component-border;
4747
@extend %db-overwrite-font-size-2xs;
4848
@extend %default-button;
49-
5049
@include tag-components.get-tag-colors("badge");
5150

5251
border-radius: variables.$db-border-radius-full;

‎packages/components/src/components/button/button.scss‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
@charset "utf-8";
2-
32
@use "@db-ux/core-foundations/build/styles/fonts";
43
@use "@db-ux/core-foundations/build/styles/variables";
54
@use "@db-ux/core-foundations/build/styles/colors";
@@ -23,7 +22,7 @@
2322

2423
// Square icon only buttons
2524
&[data-no-text="true"] {
26-
@include icons.is-icon-text-replace();
25+
@include icons.is-icon-text-replace;
2726

2827
padding: 0;
2928
inline-size: variables.$db-sizing-md;

‎packages/components/src/components/card/card.scss‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
--db-card-background-color-pressed: #{colors.$db-adaptive-bg-basic-level-1-pressed};
3030

3131
@extend %default-card;
32-
33-
@include component.get-data-spacing();
32+
@include component.get-data-spacing;
3433

3534
display: flex;
3635
flex-direction: column;

‎packages/components/src/components/checkbox/checkbox.scss‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
@mixin get-validity-color-check($key: "valid") {
2828
$variant: successful;
2929

30-
@if ($key != "valid") {
30+
@if $key != "valid" {
3131
$variant: critical;
3232
}
3333

@@ -76,11 +76,10 @@
7676

7777
.db-checkbox {
7878
@extend %helper-message;
79-
80-
@include form-components.set-default-check-element();
79+
@include form-components.set-default-check-element;
8180

8281
&:not(:has(input:disabled)) {
83-
@include form-components.get-state();
82+
@include form-components.get-state;
8483
@include form-components.get-state("active");
8584
}
8685

@@ -124,7 +123,6 @@
124123

125124
&:indeterminate {
126125
@extend %center-icon;
127-
128126
@include icons.set-icon("minus");
129127
}
130128

‎packages/components/src/components/divider/divider.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
&:not([data-variant="vertical"]) {
2222
block-size: variables.$db-border-width-3xs;
2323

24-
@include helpers.divider();
24+
@include helpers.divider;
2525

2626
&[data-width="full"] {
2727
inline-size: 100%;

0 commit comments

Comments
 (0)