From b8512dc291b7ecea354f4ba7808437a715e2e5f4 Mon Sep 17 00:00:00 2001 From: David Rohr Date: Wed, 11 May 2022 14:11:18 +0200 Subject: [PATCH 1/3] Fix misleading output --- DATA/tools/epn/gen_topo.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DATA/tools/epn/gen_topo.sh b/DATA/tools/epn/gen_topo.sh index 70c315fc6..a5c8624bc 100755 --- a/DATA/tools/epn/gen_topo.sh +++ b/DATA/tools/epn/gen_topo.sh @@ -37,7 +37,7 @@ else # Note that this does not load the module, but just needs an O2DPG path to find, which then does the bulk of the topology generation. # gen_topo_o2dpg.sh is kept compatible between O2DPG versions, thus it doesn't really depend on which O2DPG version we use at this point. if [[ -z $O2DPG_ROOT ]]; then - O2DPG_ROOT=`bash -c "module load O2DPG > /dev/null; echo \\\$O2DPG_ROOT;"` + O2DPG_ROOT=`bash -c "module load O2DPG &> /dev/null; echo \\\$O2DPG_ROOT;"` fi fi # Now we know which gen_topo_o2dpg.sh we can use, and all EPN related env variables are set, so we can run the topology generation. From df8002e0e195413bf6503cbb8f2757c35991ab26 Mon Sep 17 00:00:00 2001 From: David Rohr Date: Wed, 11 May 2022 18:53:48 +0200 Subject: [PATCH 2/3] Use IPC for local calib connections --- DATA/common/setenv_calib.sh | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/DATA/common/setenv_calib.sh b/DATA/common/setenv_calib.sh index 7d23a5e0a..68c0454f9 100755 --- a/DATA/common/setenv_calib.sh +++ b/DATA/common/setenv_calib.sh @@ -106,8 +106,6 @@ echo CALIBDATASPEC_BARREL = $CALIBDATASPEC_BARREL 1>&2 echo CALIBDATASPEC_CALO = $CALIBDATASPEC_CALO 1>&2 # proxies properties -PORT_BARREL=30453 -PORT_CALO=30454 get_proxy_connection() { if (( $# < 2 )); then @@ -117,16 +115,6 @@ get_proxy_connection() echo "second parameter is the type of connection (input/output)" exit 1 fi - - # setting the port - if [[ $1 == "barrel" ]]; then - local PORT=$PORT_BARREL - elif [[ $1 == "calo" ]]; then - local PORT=$PORT_CALO - else - echo "parameter 1 should be either 'barrel' or 'calo'" - exit 3 - fi # setting the type of connection if [[ $2 == "input" ]]; then @@ -137,8 +125,13 @@ get_proxy_connection() echo "parameter 2 should be either 'input' or 'output'" exit 2 fi - - local PROXY_CONN="--proxy-channel-name aggregator-proxy-$1 --channel-config \"name=aggregator-proxy-$1,$CONNECTION,rateLogging=1,transport=zeromq,address=tcp://localhost:$PORT\"" + + if workflow_has_parameter CALIB_LOCAL_AGGREGATOR; then + CONNECTION+=",transport=shmem,address=ipc://${UDS_PREFIX}aggregator-shm-$1" + else + CONNECTION+=",transport=zeromq" + fi + local PROXY_CONN="--proxy-channel-name aggregator-proxy-$1 --channel-config \"name=aggregator-proxy-$1,$CONNECTION,rateLogging=1\"" echo PROXY_CONN = $PROXY_CONN 1>&2 echo $PROXY_CONN From 13f481dff08aa5b7d09da4c930369ae761092de3 Mon Sep 17 00:00:00 2001 From: Chiara Zampolli Date: Wed, 11 May 2022 23:12:03 +0200 Subject: [PATCH 3/3] fix for proxy name --- DATA/common/setenv_calib.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/DATA/common/setenv_calib.sh b/DATA/common/setenv_calib.sh index 68c0454f9..d0e8d120d 100755 --- a/DATA/common/setenv_calib.sh +++ b/DATA/common/setenv_calib.sh @@ -119,8 +119,10 @@ get_proxy_connection() # setting the type of connection if [[ $2 == "input" ]]; then local CONNECTION="method=bind,type=pull" + local NAMECONNECTION="--proxy-name" elif [[ $2 == "output" ]]; then local CONNECTION="method=connect,type=push" + local NAMECONNECTION="--proxy-channel-name" else echo "parameter 2 should be either 'input' or 'output'" exit 2 @@ -131,7 +133,7 @@ get_proxy_connection() else CONNECTION+=",transport=zeromq" fi - local PROXY_CONN="--proxy-channel-name aggregator-proxy-$1 --channel-config \"name=aggregator-proxy-$1,$CONNECTION,rateLogging=1\"" + local PROXY_CONN="$NAMECONNECTION aggregator-proxy-$1 --channel-config \"name=aggregator-proxy-$1,$CONNECTION,rateLogging=1\"" echo PROXY_CONN = $PROXY_CONN 1>&2 echo $PROXY_CONN