Skip to content

Commit 82a8feb

Browse files
Merge pull request #459 from data-integrations/PLUGIN-1681
[PLUGIN-1681] Add macro support back for database config in postgres connector
2 parents 36961f1 + 717220b commit 82a8feb

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

postgresql-plugin/src/e2e-test/features/postgresql/source/PostgresqlDesignTimeWithMacro.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Feature: PostgreSQL source- Verify PostgreSQL source plugin design time macro sc
2828
Then Click on the Macro button of Property: "user" and set the value to: "postGreSQLUser"
2929
Then Click on the Macro button of Property: "password" and set the value to: "postGreSQLPassword"
3030
Then Click on the Macro button of Property: "connectionArguments" and set the value to: "postGreSQLConnectionArguments"
31-
Then Replace input plugin property: "database" with value: "databaseName"
31+
Then Click on the Macro button of Property: "database" and set the value to: "postGreSQLDatabase"
3232
Then Enter input plugin property: "referenceName" with value: "sourceRef"
3333
Then Enter textarea plugin property: "importQuery" with value: "selectQuery"
3434
Then Validate "PostgreSQL" plugin properties

postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresConnectorConfig.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package io.cdap.plugin.postgres;
1818

1919
import io.cdap.cdap.api.annotation.Description;
20+
import io.cdap.cdap.api.annotation.Macro;
2021
import io.cdap.cdap.api.annotation.Name;
2122
import io.cdap.plugin.db.connector.AbstractDBSpecificConnectorConfig;
2223

@@ -38,6 +39,7 @@ public PostgresConnectorConfig(String host, int port, String user, String passwo
3839

3940
@Name(NAME_DATABASE)
4041
@Description("Database to connect to.")
42+
@Macro
4143
private String database;
4244

4345
@Override

0 commit comments

Comments
 (0)