Commit 9efcad5
committed
Don't ignore exceptions in elementwise reference implementations
For some reason, "except OverflowError" was changed to "except Exception" in
e72184e. For now I have removed the except entirely, but it's possible we may
need to keep the handling for OverflowError.
There are several issues with tests that this was masking, which I have not
fixed yet. Quite a few tests are not testing the complex implementations
correctly because they are using math instead of cmath, for example. See also
data-apis/array-api-compat#183.1 parent 635843d commit 9efcad5
1 file changed
+3
-12
lines changedLines changed: 3 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
| 245 | + | |
249 | 246 | | |
250 | 247 | | |
251 | 248 | | |
| |||
317 | 314 | | |
318 | 315 | | |
319 | 316 | | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
| 317 | + | |
324 | 318 | | |
325 | 319 | | |
326 | 320 | | |
| |||
392 | 386 | | |
393 | 387 | | |
394 | 388 | | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
| 389 | + | |
399 | 390 | | |
400 | 391 | | |
401 | 392 | | |
| |||
0 commit comments