Skip to content

Commit 4bb8883

Browse files
authored
Emit changelog excerpt only in the email and not on pub CLI. (#8938)
1 parent 057bb04 commit 4bb8883

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

app/lib/package/backend.dart

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1130,6 +1130,8 @@ class PackageBackend {
11301130
}) async {
11311131
final sw = Stopwatch()..start();
11321132
final uploadMessages = <String>[];
1133+
// messages that are sent in the email but not returned as upload messages to the pub client
1134+
final additionalEmailMessages = <String>[];
11331135
final newVersion = entities.packageVersion;
11341136
final [currentDartSdk, currentFlutterSdk] = await Future.wait([
11351137
getCachedDartSdkVersion(lastKnownStable: toolStableDartSdkVersion),
@@ -1176,7 +1178,7 @@ class PackageBackend {
11761178
changelogContent: entities.changelogAsset?.textContent,
11771179
);
11781180
if (changelogExcerpt != null && changelogExcerpt.isNotEmpty) {
1179-
uploadMessages
1181+
additionalEmailMessages
11801182
.add('Excerpt of the changelog:\n```\n$changelogExcerpt\n```');
11811183
}
11821184

@@ -1279,7 +1281,10 @@ class PackageBackend {
12791281
displayId: agent.displayId,
12801282
authorizedUploaders:
12811283
uploaderEmails.map((email) => EmailAddress(email)).toList(),
1282-
uploadMessages: uploadMessages,
1284+
uploadMessages: [
1285+
...uploadMessages,
1286+
...additionalEmailMessages,
1287+
],
12831288
);
12841289
final outgoingEmail = emailBackend.prepareEntity(email);
12851290

0 commit comments

Comments
 (0)