Fix tests for new flutter tooling change and Dart cmd line change (#2742)

* Fix tests for new flutter tooling change and Dart cmd line change

* tweak to batch file, snippets get

Author: jcollins-g

lib/src/dartdoc_options.dart

@@ -230,9 +230,9 @@ class ToolConfiguration {
         return isDartCommand;
       }
 
-      var executableRelatvePath = command.removeAt(0);
+      var executableRelativePath = command.removeAt(0);
       var executable = pathContext.canonicalize(
-          pathContext.join(canonicalYamlPath, executableRelatvePath));
+          pathContext.join(canonicalYamlPath, executableRelativePath));
       validateExecutable(executable);
       if (setupCommand != null) {
         var setupExecutableRelativePath = setupCommand.removeAt(0);

test/tool_runner_test.dart

@@ -15,6 +15,7 @@ import 'package:test/test.dart';
 import 'package:yaml/yaml.dart';
 
 final Directory _testPackageDir = Directory('testing/test_package');
+final Directory _toolExecutableDir = Directory('testing/tool_executables');
 
 void main() {
   ToolConfiguration toolMap;
@@ -50,10 +51,9 @@ void main() {
     }
     expect(result?.exitCode, equals(0));
     setupFile = File(path.join(tempDir.path, 'setup.stamp'));
-    // We use the Dart executable for our "non-dart" tool
-    // test, because it's the only executable that we know the
-    // exact location of that works on all platforms.
-    var nonDartExecutable = Platform.resolvedExecutable;
+    var nonDartName = Platform.isWindows ? 'non_dart.bat' : 'non_dart.sh';
+    var nonDartExecutable =
+        path.join(_toolExecutableDir.absolute.path, nonDartName);
     // Have to replace backslashes on Windows with double-backslashes, to
     // escape them for YAML parser.
     var yamlMap = '''
@@ -153,7 +153,7 @@ echo:
         toolErrorCallback: errorCallback,
       );
       expect(errors, isEmpty);
-      expect(result, isEmpty); // Output is on stderr.
+      expect(result, startsWith('this is not dart'));
     });
     test('can invoke a pre-snapshotted tool', () async {
       var result = await runner.run(

testing/tool_executables/non_dart.bat

@@ -0,0 +1 @@
+@echo this is not dart

testing/tool_executables/non_dart.sh

@@ -0,0 +1,2 @@
+#!/bin/sh
+echo this is not dart

tool/grind.dart

@@ -916,8 +916,7 @@ Future<List<Map>> _buildFlutterDocs(
   );
   await flutterRepo.launcher.runStreamed(
     flutterRepo.cachePub,
-    ['get'],
-    workingDirectory: path.join(flutterPath, 'dev', 'snippets'),
+    ['global', 'activate', 'snippets'],
   );
   // TODO(jcollins-g): flutter's dart SDK pub tries to precompile the universe
   // when using -spath.  Why?