Adding support for DDC's Library Bundle module system. #4303
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
| bool emitDebugSymbols, | ||
| bool canaryFeatures, | ||
| bool ddcModules, | ||
| bool ddcLibraryBundle, |
There was a problem hiding this comment.
Optional, entirely up to you: this many adjacent positional bools makes me nervous, how about switching them to named?
There was a problem hiding this comment.
Yes please! I'd love to get to a place where we only use positional arguments for simple functions with one or two parameters and then default to using required named everywhere else, but obviously we don't have to do this all at once 😄
| ); | ||
| }); | ||
| }); | ||
| group('regression tests', () { |
There was a problem hiding this comment.
Super nitpicky optional nitpick: blank line here to give the group a bit of breathing space? :)
| @@ -1,3 +1,7 @@ | |||
| ## 5.1.5 | |||
|
|
|||
| - Adding support for DDC's Library Bundle module system. | |||
There was a problem hiding this comment.
Please use the direct form, "Add support for ...", or just "Support DDC's ..." would also work.
| @@ -1,5 +1,7 @@ | |||
| ## 4.4.6 | |||
| ## 4.4.7 | |||
| - Adding support for DDC's Library Bundle module system. | |||
There was a problem hiding this comment.
Please use the direct form "Add support for DDC's ..." or just "Support DDC's ...".
Not sure if this is a complete change or part of the work? If it's complete then maybe it's worth saying a bit more about the feature from the user's point of view, if you don't plan to release then the version should be 4.4.7-wip please :)
| bool emitDebugSymbols, | ||
| bool canaryFeatures, | ||
| bool ddcModules, | ||
| bool ddcLibraryBundle, |
There was a problem hiding this comment.
Yes please! I'd love to get to a place where we only use positional arguments for simple functions with one or two parameters and then default to using required named everywhere else, but obviously we don't have to do this all at once 😄
| /// Whether or not to emit DDC entrypoints that support web hot reload. | ||
| /// | ||
| /// Web hot reload is only supported for DDC's Library Bundle module system. | ||
| /// Only supported for DDC's Library Bundle module system. |
There was a problem hiding this comment.
Do we have any checks to enforce this? Or does useWebHotReload == true just do nothing if we're not using the new module system?
3 participants
This module system - in conjunction with the Frontend Server - supports web hot reload. This is part of an effort to deprecate DDC's older module systems.
Notable updates:
ddc-library-bundleflag through several builders.webHotReloadand the new module system. These should be consistent now.