Skip to content

Conversation

@kgal-akl
Copy link

@kgal-akl kgal-akl commented Oct 30, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within tabpane
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have tabpane

In addition, please fill out the following to help reviewers understand this pull request:

Description

Part of dapr/components-contrib#4036. Opened instead of #4910 as PR 4910 was targeted towards release v1.16.

Issue reference

@kgal-akl
Copy link
Author

@msfussell FYI.

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgal-akl Great PR and looking forward to getting this into the release. Left a few comments

@msfussell msfussell added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Dec 4, 2025
@msfussell msfussell added this to the 1.17 milestone Dec 4, 2025
kgal-akl and others added 6 commits December 4, 2025 14:40
Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
* Setup 1.17

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>

* Update deployment token, remove obsolete field

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>

* Add skip_deploy_on_missing_secrets option

This field is required when people create a PR based on a branch in their fork and the secret is not available.

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>

---------

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
* Added bianry cloudevent exmaples and explanation

Signed-off-by: adam shamis <adamshamis.dev@gmail.com>

* tabpane line was missing

Signed-off-by: adam shamis <adamshamis.dev@gmail.com>

* topic was misproununced

Signed-off-by: adam shamis <adamshamis.dev@gmail.com>

---------

Signed-off-by: adam shamis <adamshamis.dev@gmail.com>
Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
@kgal-akl
Copy link
Author

kgal-akl commented Dec 4, 2025

@msfussell - Done. Let me know if anything else is needed. I'm still waiting for review of dapr/components-contrib#4036 and dapr/dapr#9181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-code-pr The code PR needs to be merged before the docs are updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants