Skip to content

Commit 4ea27e4

Browse files
committed
Inspection related changes.
1 parent bb2e6dd commit 4ea27e4

35 files changed

+105
-23
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,8 @@ the drop-down is toggled closed after the user selectes a date/time.
264264

265265
## I18N
266266

267-
All internationalization is handled by Moment.js, see Moment's documention for details.
267+
All internationalization is handled by Moment.js, see Moment's documentation for details.
268+
In most cases, all that is needed is a call to ```moment.locale(String)```
268269

269270
# Screenshots
270271

contributing.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,21 @@ cd angular-bootstrap-datetimepicker
1414
npm install -g grunt-cli
1515
npm install
1616
git checkout develop # all patches against develop branch, please!
17-
grunt # this runs tests and jshint
17+
gulp # this runs jscs, jshint, complexity checks, and unit tests.
1818
```
1919

2020
Very important notes
2121
====================
2222

2323
* **Pull pull requests to the `master` branch will be closed.** Please submit all pull requests to the `develop` branch.
2424
* **Pull requests will not be merged without unit tests.**
25-
* **Do not include the minified files in your pull request.**
25+
* **Do not include the minified files in your pull request.**
26+
* **Have good tests. If you don't have tests for very line and branch in your changes, I won't accept the PR.
27+
* **If your PR fails the CI build, I won't look at it.
2628

27-
Grunt tasks
29+
Gulp tasks
2830
===========
2931

30-
We use Grunt for managing the build. Here are some useful Grunt tasks:
32+
We use Gulp for managing the build. Here are some useful Gulp tasks:
3133

32-
* `grunt` The default task lints the code and runs the tests. You should make sure you do this before submitting a PR.
34+
* `gulp` The default task checks the coding style, lints the code, calculates complexity, runs the tests, and enforces code coverage. You should make sure you do this before submitting a PR.

demo/demo-controller.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
/*globals angular, moment, $, console*/
1+
/*globals angular, moment, $ */
22

33
angular.module('demo.demoController', [])
44
.controller('demoController', [
55
'$scope',
6-
function ($scope) {
6+
'$log',
7+
function ($scope, $log) {
78
'use strict';
89
$scope.controllerName = 'demoController';
910

@@ -32,7 +33,7 @@ angular.module('demo.demoController', [])
3233
// However, can write this function to take any
3334
// action necessary once the user has selected a
3435
// date/time using the picker
35-
console.log(newDate);
36+
$log.info(newDate);
3637
$('#dropdown3').dropdown('toggle');
3738
};
3839

@@ -46,16 +47,16 @@ angular.module('demo.demoController', [])
4647

4748

4849
$scope.guardianOnSetTime = function ($index, guardian, newDate, oldDate) {
49-
console.log($index);
50-
console.log(guardian.name);
51-
console.log(newDate);
52-
console.log(oldDate);
50+
$log.info($index);
51+
$log.info(guardian.name);
52+
$log.info(newDate);
53+
$log.info(oldDate);
5354
angular.element('#guardian' + $index).dropdown('toggle');
5455
};
5556

5657
$scope.beforeRender = function ($dates) {
5758
var index = Math.floor(Math.random() * $dates.length);
58-
console.log(index);
59+
$log.info(index);
5960
$dates[index].selectable = false;
6061
};
6162

4.79 KB
Loading
6.37 KB
Loading
1.37 KB
Loading
1.74 KB
Loading
2.46 KB
Loading
3.25 KB
Loading
3.77 KB
Loading

0 commit comments

Comments
 (0)