Skip to content

Commit 3de0d25

Browse files
committed
docs(Readme): Update Date Range picker example in the readme and add it to the demo page.
The original example did not have code to re-render the directive when the start or end date changed. It is now a more complete example. Fix #315
1 parent 9c3d569 commit 3de0d25

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -341,11 +341,11 @@ the drop-down is toggled closed after the user selectes a date/time.
341341
### Create a date range picker with validation controls
342342
```html
343343
<div class="dropdown form-group">
344-
<label for="dateRangeStart">Start Date</label>
344+
<label>Start Date</label>
345345
<a class="dropdown-toggle" id="dropdownStart" role="button" data-toggle="dropdown" data-target="#"
346346
href="#">
347347
<div class="input-group date">
348-
<input id="dateRangeStart" type="text" class="form-control" data-ng-model="dateRangeStart">
348+
<input type="text" class="form-control" data-ng-model="dateRangeStart">
349349
<span class="input-group-addon"><i class="glyphicon glyphicon-calendar"></i></span>
350350
</div>
351351
</a>
@@ -358,7 +358,7 @@ the drop-down is toggled closed after the user selectes a date/time.
358358
</div>
359359

360360
<div class="dropdown form-group">
361-
<label for="dateRangeStart">End Date</label>
361+
<label>End Date</label>
362362
<a class="dropdown-toggle" id="dropdownEnd" role="button" data-toggle="dropdown" data-target="#"
363363
href="#">
364364
<div class="input-group date">
@@ -385,12 +385,10 @@ $scope.startDateBeforeRender = startDateBeforeRender
385385
$scope.startDateOnSetTime = startDateOnSetTime
386386

387387
function startDateOnSetTime () {
388-
selectable = (!selectable);
389388
$scope.$broadcast('start-date-changed');
390389
}
391390

392391
function endDateOnSetTime () {
393-
selectable = (!selectable);
394392
$scope.$broadcast('end-date-changed');
395393
}
396394

demo/demo-controller.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,10 @@
126126
}
127127

128128
function startDateOnSetTime () {
129-
selectable = (!selectable);
130129
$scope.$broadcast('start-date-changed');
131130
}
132131

133132
function endDateOnSetTime () {
134-
selectable = (!selectable);
135133
$scope.$broadcast('end-date-changed');
136134
}
137135

demo/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -413,11 +413,11 @@ <h4>Every time you select a start date, dates before the start date are disabled
413413

414414
<div class="well">
415415
<div class="dropdown form-group">
416-
<label for="dateRangeStart">Start Date</label>
416+
<label>Start Date</label>
417417
<a class="dropdown-toggle" id="dropdownStart" role="button" data-toggle="dropdown" data-target="#"
418418
href="#">
419419
<div class="input-group date">
420-
<input id="dateRangeStart" type="text" class="form-control" data-ng-model="dateRangeStart">
420+
<input type="text" class="form-control" data-ng-model="dateRangeStart">
421421
<span class="input-group-addon"><i class="glyphicon glyphicon-calendar"></i></span>
422422
</div>
423423
</a>
@@ -430,7 +430,7 @@ <h4>Every time you select a start date, dates before the start date are disabled
430430
</div>
431431

432432
<div class="dropdown form-group">
433-
<label for="dateRangeStart">End Date</label>
433+
<label>End Date</label>
434434
<a class="dropdown-toggle" id="dropdownEnd" role="button" data-toggle="dropdown" data-target="#"
435435
href="#">
436436
<div class="input-group date">

0 commit comments

Comments
 (0)