Move qrcodejs to libraries.yml

[therealssj]

qrcode js should be in the libraries.yml file.
Currently it is defined in hook_library.

Though we are not using this currently, should we remove this altogether given it requires you to add inline js?

I tried a lot but could not find any info on how to add inline js in drupal 8.

[nerdstein]

In Drupal 7, drupal_add_js could be used to load JS inline (when appropriate). This has been replaced by #attached, seen here: https://www.drupal.org/node/2169605

[therealssj]

You can add external libraries but adding inline js gives an error.
A discussion is going on about it here https://www.drupal.org/node/2391025

[nerdstein]

We may need to wait on that until the discussion comes to fruition. In the interim, it may be wise to leave it in the libraries.yml file

[therealssj]

One thing we can do is, append the inline js at the end of qrcode.min.js file or create a new file and add that as a library.