search by name doesn't work

[si-the-pie]

Shaun sent this to the mailing list today:

The search by name on the mobile site doesn't seem to be working with the attached error on my Samsung galaxy s2 with ice cream sandwich in google chrome beta. The same problem occurs in the built in browser. Mobile Firefox fails too. I sometimes get to the page http://m.cyclestreets.net/route-without-js.php

I've easily reproduced it at:

http://m.cyclestreets.net/#route-by-address

[si-the-pie]

The behaviour of the page http://m.cyclestreets.net/#route-by-address varies according to whether you've just arrived from the home page, or are left on the page following an error.

When just arrived it mostly works. But after an error the find button routes to the missing 'route-without-js.php' page, which should be treated as 'the javascript has broken'.

[si-the-pie]

I think the problem is occurring because at

https://github.com/cyclestreets/mobileweb/blob/master/js/cyclestreets.js#L956

in the function geocodeWithCycleStreets(place_from,place_to)

it is not clear to me how current_latlng ever gets a non null value at this point.

It seems that some how gpsSuccess() needs to run, but if it does then other things are expected too, like a map page to move an icon. I must say I'm rather confused here, I have tried to refactor it a bit but got stuck.