fixed local name detection for comprehensions

Author: craigbarratt

custom_components/pyscript/eval.py

@@ -1708,6 +1708,10 @@ async def get_names_set(self, arg, names, nonlocal_names=None, global_names=None
                         for name in await self.get_target_names(item.optional_vars):
                             local_names.add(name)
                             names.add(name)
+            elif cls_name in {"ListComp", "DictComp", "SetComp"}:
+                target_vars, _ = await self.loopvar_scope_save(arg.generators)
+                for name in target_vars:
+                    local_names.add(name)
             elif cls_name == "Try":
                 for handler in arg.handlers:
                     if handler.name is not None:

tests/test_unit_eval.py

@@ -254,6 +254,12 @@ def no_op(i):
         "{f'{i}+{k}':i+k for i in range(3) for k in range(3) if k <= i}",
         {"0+0": 0, "1+0": 1, "1+1": 2, "2+0": 2, "2+1": 3, "2+2": 4},
     ],
+    ["def f(l=5): return [i for i in range(l)];\nf(6)", [0, 1, 2, 3, 4, 5]],
+    ["def f(l=5): return {i+j for i,j in zip(range(l), range(l))};\nf()", {0, 2, 4, 6, 8}],
+    [
+        "def f(l=5): return {i:j for i,j in zip(range(l), range(1,l+1))};\nf()",
+        {0: 1, 1: 2, 2: 3, 3: 4, 4: 5},
+    ],
     [
         """
 d = {"x": 1, "y": 2, "z": 3}