Skip to content

Commit 7a2eb3c

Browse files
committed
cgroup/cpuset: Fix obsolete comment in cpuset_css_offline()
JIRA: https://issues.redhat.com/browse/RHEL-107751 commit 6e6f917 Author: Waiman Long <longman@redhat.com> Date: Mon, 7 Apr 2025 17:21:04 -0400 cgroup/cpuset: Fix obsolete comment in cpuset_css_offline() Move the partition disablement comment from cpuset_css_offline() to cpuset_css_killed() and reword it to remove the remnant of sched.partition. Suggested-by: Michal Koutný <mkoutny@suse.com> Signed-off-by: Waiman Long <longman@redhat.com> Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Waiman Long <longman@redhat.com>
1 parent 6b51c7e commit 7a2eb3c

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

kernel/cgroup/cpuset.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3561,11 +3561,7 @@ static int cpuset_css_online(struct cgroup_subsys_state *css)
35613561
* will call rebuild_sched_domains_locked(). That is not needed
35623562
* in the default hierarchy where only changes in partition
35633563
* will cause repartitioning.
3564-
*
3565-
* If the cpuset has the 'sched.partition' flag enabled, simulate
3566-
* turning 'sched.partition" off.
35673564
*/
3568-
35693565
static void cpuset_css_offline(struct cgroup_subsys_state *css)
35703566
{
35713567
struct cpuset *cs = css_cs(css);
@@ -3583,6 +3579,11 @@ static void cpuset_css_offline(struct cgroup_subsys_state *css)
35833579
cpus_read_unlock();
35843580
}
35853581

3582+
/*
3583+
* If a dying cpuset has the 'cpus.partition' enabled, turn it off by
3584+
* changing it back to member to free its exclusive CPUs back to the pool to
3585+
* be used by other online cpusets.
3586+
*/
35863587
static void cpuset_css_killed(struct cgroup_subsys_state *css)
35873588
{
35883589
struct cpuset *cs = css_cs(css);

0 commit comments

Comments
 (0)