Skip to content

Commit 74d64a4

Browse files
committed
cgroup/cpuset: Remove stale text
JIRA: https://issues.redhat.com/browse/RHEL-107751 commit eb1dd15 Author: Costa Shulyupin <costa.shul@redhat.com> Date: Wed, 4 Dec 2024 13:04:41 +0200 cgroup/cpuset: Remove stale text Task's cpuset pointer was removed by commit 8793d85 ("Task Control Groups: make cpusets a client of cgroups") Paragraph "The task_lock() exception ...." was removed by commit 2df167a ("cgroups: update comments in cpuset.c") Remove stale text: We also require taking task_lock() when dereferencing a task's cpuset pointer. See "The task_lock() exception", at the end of this comment. Accessing a task's cpuset should be done in accordance with the guidelines for accessing subsystem state in kernel/cgroup.c and reformat. Co-developed-by: Michal Koutný <mkoutny@suse.com> Co-developed-by: Waiman Long <longman@redhat.com> Signed-off-by: Costa Shulyupin <costa.shul@redhat.com> Acked-by: Waiman Long <longman@redhat.com> Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Waiman Long <longman@redhat.com>
1 parent 6ea4721 commit 74d64a4

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

kernel/cgroup/cpuset.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,8 @@ static struct cpuset top_cpuset = {
201201

202202
/*
203203
* There are two global locks guarding cpuset structures - cpuset_mutex and
204-
* callback_lock. We also require taking task_lock() when dereferencing a
205-
* task's cpuset pointer. See "The task_lock() exception", at the end of this
206-
* comment. The cpuset code uses only cpuset_mutex. Other kernel subsystems
207-
* can use cpuset_lock()/cpuset_unlock() to prevent change to cpuset
204+
* callback_lock. The cpuset code uses only cpuset_mutex. Other kernel
205+
* subsystems can use cpuset_lock()/cpuset_unlock() to prevent change to cpuset
208206
* structures. Note that cpuset_mutex needs to be a mutex as it is used in
209207
* paths that rely on priority inheritance (e.g. scheduler - on RT) for
210208
* correctness.
@@ -233,9 +231,6 @@ static struct cpuset top_cpuset = {
233231
* The cpuset_common_seq_show() handlers only hold callback_lock across
234232
* small pieces of code, such as when reading out possibly multi-word
235233
* cpumasks and nodemasks.
236-
*
237-
* Accessing a task's cpuset should be done in accordance with the
238-
* guidelines for accessing subsystem state in kernel/cgroup.c
239234
*/
240235

241236
static DEFINE_MUTEX(cpuset_mutex);

0 commit comments

Comments
 (0)