Skip to content

Commit 3a55f9d

Browse files
committed
x86/smpboot: avoid SMT domain attach/destroy if SMT is not enabled
JIRA: https://issues.redhat.com/browse/RHEL-118964 commit f79c9aa Author: Li Chen <chenl311@chinatelecom.cn> Date: Thu Jul 10 18:57:10 2025 +0800 x86/smpboot: avoid SMT domain attach/destroy if SMT is not enabled Currently, the SMT domain is added into sched_domain_topology by default. If cpu_attach_domain() finds that the CPU SMT domain’s cpumask_weight is just 1, it will destroy it. On a large machine, such as one with 512 cores, this results in 512 redundant domain attach/destroy operations. Avoid these unnecessary operations by simply checking cpu_smt_num_threads and skip SMT domain if the SMT domain is not enabled. Suggested-by: K Prateek Nayak <kprateek.nayak@amd.com> Signed-off-by: Li Chen <chenl311@chinatelecom.cn> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com> Tested-by: K Prateek Nayak <kprateek.nayak@amd.com> Link: https://lore.kernel.org/r/20250710105715.66594-5-me@linux.beauty Signed-off-by: Phil Auld <pauld@redhat.com>
1 parent 26b41d9 commit 3a55f9d

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

arch/x86/kernel/smpboot.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,8 @@ static struct sched_domain_topology_level x86_topology[] = {
518518

519519
static void __init build_sched_topology(void)
520520
{
521+
struct sched_domain_topology_level *topology = x86_topology;
522+
521523
/*
522524
* When there is NUMA topology inside the package invalidate the
523525
* PKG domain since the NUMA domains will auto-magically create the
@@ -528,7 +530,15 @@ static void __init build_sched_topology(void)
528530

529531
memset(&x86_topology[pkgdom], 0, sizeof(x86_topology[pkgdom]));
530532
}
531-
set_sched_topology(x86_topology);
533+
534+
/*
535+
* Drop the SMT domains if there is only one thread per-core
536+
* since it'll get degenerated by the scheduler anyways.
537+
*/
538+
if (cpu_smt_num_threads <= 1)
539+
++topology;
540+
541+
set_sched_topology(topology);
532542
}
533543

534544
void set_cpu_sibling_map(int cpu)

0 commit comments

Comments
 (0)