scsi: lpfc: Move clearing of HBA_SETUP flag to before lpfc_sli4_queue_unset

JIRA: https://issues.redhat.com/browse/RHEL-103752

commit a28d10a
Author: Justin Tee <justin.tee@broadcom.com>
Date:   Wed Jun 18 12:21:34 2025 -0700

    scsi: lpfc: Move clearing of HBA_SETUP flag to before lpfc_sli4_queue_unset

    Move clearing of HBA_SETUP flag out of lpfc_sli_brdrestart_s4 and before
    lpfc_sli4_queue_unset.  lpfc_sli4_queue_unset kfrees phba queues, so
    clear the HBA_SETUP atomic flag to signal that the phba struct is no
    longer initialized.

    Also, add a check for the HBA_SETUP flag in the lpfc_sli4_io_xri_aborted
    routine before dereferencing the ELS WQ.

    Signed-off-by: Justin Tee <justin.tee@broadcom.com>
    Link: https://lore.kernel.org/r/20250618192138.124116-10-justintee8345@gmail.com
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: Paul Ely <paely@redhat.com>

Author: Paul Ely

drivers/scsi/lpfc/lpfc_scsi.c

@@ -536,7 +536,8 @@ lpfc_sli4_io_xri_aborted(struct lpfc_hba *phba,
 			psb = container_of(iocbq, struct lpfc_io_buf, cur_iocbq);
 			psb->flags &= ~LPFC_SBUF_XBUSY;
 			spin_unlock_irqrestore(&phba->hbalock, iflag);
-			if (!list_empty(&pring->txq))
+			if (test_bit(HBA_SETUP, &phba->hba_flag) &&
+			    !list_empty(&pring->txq))
 				lpfc_worker_wake_up(phba);
 			return;
 		}

drivers/scsi/lpfc/lpfc_sli.c

@@ -5170,7 +5170,6 @@ lpfc_sli4_brdreset(struct lpfc_hba *phba)
 	phba->link_events = 0;
 	phba->pport->fc_myDID = 0;
 	phba->pport->fc_prevDID = 0;
-	clear_bit(HBA_SETUP, &phba->hba_flag);
 
 	spin_lock_irq(&phba->hbalock);
 	psli->sli_flag &= ~(LPFC_PROCESS_LA);
@@ -5287,6 +5286,7 @@ lpfc_sli_brdrestart_s4(struct lpfc_hba *phba)
 			"0296 Restart HBA Data: x%x x%x\n",
 			phba->pport->port_state, psli->sli_flag);
 
+	clear_bit(HBA_SETUP, &phba->hba_flag);
 	lpfc_sli4_queue_unset(phba);
 
 	rc = lpfc_sli4_brdreset(phba);