From ef398cdace49bd44432cfc1b915aa6e9ae150a3c Mon Sep 17 00:00:00 2001
From: Ude F <5TDg9@users.noreply.github.com>
Date: Wed, 10 Dec 2025 01:26:40 +0100
Subject: [PATCH] Fix banner.php for PHP 8

Ensure the 'approval' key exists in the metadata array.
On PHP 8, accessing a missing array key (e.g. $meta['approval']) triggers a "Undefined array key" warning, so we must check first.
---
 action/banner.php | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/action/banner.php b/action/banner.php
index 107834d..f7856fa 100644
--- a/action/banner.php
+++ b/action/banner.php
@@ -32,9 +32,12 @@ function handle_display_banner(&$event, $param) {
             return;
         }
 
-        $meta = $INFO['meta'];
+        $meta = $INFO['meta'] ?? array();
 
-        if (!$meta['approval']) {
+        // Ensure the 'approval' key exists in the metadata array.
+        // On PHP 8, accessing a missing array key (e.g. $meta['approval'])
+        // triggers a "Undefined array key" warning, so we must check first.
+        if (!isset($meta['approval']) || !is_array($meta['approval'])) {
             $meta['approval'] = array();
         }