Skip to content

Commit ef0fc26

Browse files
authored
test(events): ensure event creation errors are properly handled (#547)
Signed-off-by: Marc Nuri <marc@marcnuri.com>
1 parent 2f5062f commit ef0fc26

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pkg/mcp/events_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func (s *EventsSuite) TestEventsList() {
3232
s.Run("events_list (with events)", func() {
3333
client := kubernetes.NewForConfigOrDie(envTestRestConfig)
3434
for _, ns := range []string{"default", "ns-1"} {
35-
_, _ = client.CoreV1().Events(ns).Create(s.T().Context(), &v1.Event{
35+
_, eventCreateErr := client.CoreV1().Events(ns).Create(s.T().Context(), &v1.Event{
3636
ObjectMeta: metav1.ObjectMeta{
3737
Name: "an-event-in-" + ns,
3838
},
@@ -45,6 +45,7 @@ func (s *EventsSuite) TestEventsList() {
4545
Type: "Normal",
4646
Message: "The event message",
4747
}, metav1.CreateOptions{})
48+
s.Require().NoError(eventCreateErr, "failed to create event in namespace %s", ns)
4849
}
4950
s.Run("events_list()", func() {
5051
toolResult, err := s.CallTool("events_list", map[string]interface{}{})

0 commit comments

Comments
 (0)