Add some tests to override

Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>

Author: aljesusg

pkg/config/config_default.go

@@ -6,20 +6,24 @@ import (
 	"github.com/BurntSushi/toml"
 )
 
+// DefaultOverridesProvider is used to retrieve the overrides.
+// It points to defaultOverrides by default, and can be replaced in tests.
+var DefaultOverridesProvider = defaultOverrides
+
 func Default() *StaticConfig {
 	defaultConfig := StaticConfig{
 		ListOutput: "table",
 		Toolsets:   []string{"core", "config", "helm"},
 	}
-	overrides := defaultOverrides()
+	overrides := DefaultOverridesProvider()
 	mergedConfig := mergeConfig(defaultConfig, overrides)
 	return &mergedConfig
 }
 
 // HasDefaultOverrides indicates whether the internal defaultOverrides function
 // provides any overrides or an empty StaticConfig.
 func HasDefaultOverrides() bool {
-	overrides := defaultOverrides()
+	overrides := DefaultOverridesProvider()
 	var buf bytes.Buffer
 	if err := toml.NewEncoder(&buf).Encode(overrides); err != nil {
 		// If marshaling fails, assume no overrides

pkg/toolsets/kiali/toolset_name_override_test.go

@@ -0,0 +1,62 @@
+package kiali
+
+import (
+	"testing"
+
+	"github.com/containers/kubernetes-mcp-server/pkg/config"
+	"github.com/containers/kubernetes-mcp-server/pkg/toolsets"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestKialiToolsetNameOverridesToOssm(t *testing.T) {
+	// Swap the default overrides provider to simulate downstream override
+	orig := config.DefaultOverridesProvider
+	config.DefaultOverridesProvider = func() config.StaticConfig {
+		return config.StaticConfig{
+			ToolsetKialiName: "ossm",
+		}
+	}
+	defer func() { config.DefaultOverridesProvider = orig }()
+
+	// Snapshot current registry to restore after test
+	originalToolsets := toolsets.Toolsets()
+	defer func() {
+		toolsets.Clear()
+		for _, ts := range originalToolsets {
+			toolsets.Register(ts)
+		}
+	}()
+
+	// Ensure a clean registry and register a fresh instance of this toolset
+	toolsets.Clear()
+	toolsets.Register(&Toolset{})
+
+	names := toolsets.ToolsetNames()
+	assert.Contains(t, names, "ossm", "expected toolset name to be overridden to 'ossm'")
+	assert.NotContains(t, names, "kiali", "expected original toolset name 'kiali' to be replaced")
+}
+
+func TestKialiToolsetNameDefaultsToKiali(t *testing.T) {
+	// Force no overrides to be returned
+	orig := config.DefaultOverridesProvider
+	config.DefaultOverridesProvider = func() config.StaticConfig {
+		return config.StaticConfig{}
+	}
+	defer func() { config.DefaultOverridesProvider = orig }()
+
+	// Snapshot current registry to restore after test
+	originalToolsets := toolsets.Toolsets()
+	defer func() {
+		toolsets.Clear()
+		for _, ts := range originalToolsets {
+			toolsets.Register(ts)
+		}
+	}()
+
+	toolsets.Clear()
+	toolsets.Register(&Toolset{})
+
+	names := toolsets.ToolsetNames()
+	assert.Contains(t, names, "kiali", "expected default toolset name to be 'kiali' when no override provided")
+	assert.NotContains(t, names, "ossm", "did not expect 'ossm' without override")
+}

pkg/toolsets/kiali/toolset_prefix_test.go

@@ -0,0 +1,29 @@
+package kiali
+
+import (
+	"context"
+	"strings"
+	"testing"
+
+	"github.com/containers/kubernetes-mcp-server/pkg/kubernetes"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+type fakeOpenShiftTrue struct{}
+
+func (fakeOpenShiftTrue) IsOpenShift(context.Context) bool { return true }
+
+func TestKialiToolsUseOssmPrefixWhenOpenShift(t *testing.T) {
+	var o kubernetes.Openshift = fakeOpenShiftTrue{}
+	tools := (&Toolset{}).GetTools(o)
+
+	require.NotEmpty(t, tools, "expected kiali toolset to expose tools")
+	for _, tool := range tools {
+		name := tool.Tool.Name
+		assert.Truef(t, strings.HasPrefix(name, "ossm_"), "expected tool name to start with 'ossm_', got %q", name)
+		assert.Falsef(t, strings.HasPrefix(name, "kiali_"), "did not expect tool name to start with 'kiali_' when OpenShift, got %q", name)
+	}
+}
+
+