Add form validation to transferPackageAction()

Author: stevenrombauts

src/Controller/PackageController.php

@@ -1019,6 +1019,10 @@ public function transferPackageAction(Request $req, #[MapEntity] Package $packag
                 $logger->critical($e->getMessage(), ['exception', $e]);
                 $this->addFlash('error', 'The package could not be transferred.');
             }
+        } elseif (!$form->isValid()) {
+            foreach ($form->getErrors(true, true) as $error) {
+                $this->addFlash('error', $error->getMessage());
+            }
         }
 
         return $this->redirectToRoute('view_package', ['name' => $package->getName()]);

src/Form/Model/TransferPackageRequest.php

@@ -13,12 +13,14 @@
 namespace App\Form\Model;
 
 use App\Entity\User;
+use App\Validator\Constraints\TransferPackageValidMaintainersList;
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
 
 class TransferPackageRequest
 {
     /** @var Collection<int, User> */
+    #[TransferPackageValidMaintainersList]
     private Collection $maintainers;
 
     public function __construct()

src/Form/Type/MaintainerType.php

@@ -15,9 +15,10 @@
 use App\Entity\User;
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Component\Form\AbstractType;
+use Symfony\Component\Form\CallbackTransformer;
+use Symfony\Component\Form\Exception\TransformationFailedException;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormBuilderInterface;
-use Symfony\Component\Form\CallbackTransformer;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
@@ -41,7 +42,18 @@ function (?string $username): ?User {
                     return null;
                 }
 
-                return $this->em->getRepository(User::class)->findOneByUsernameOrEmail($username);
+                $user = $this->em->getRepository(User::class)->findOneByUsernameOrEmail($username);
+
+                if ($user === null) {
+                    $failure = new TransformationFailedException(sprintf('User "%s" does not exist.', $username));
+                    $failure->setInvalidMessage('The given "{{ value }}" value is not a valid username or email.', [
+                        '{{ value }}' => $username,
+                    ]);
+
+                    throw $failure;
+                }
+
+                return $user;
             }
         ));
     }

src/Validator/Constraints/TransferPackageValidMaintainersList.php

@@ -0,0 +1,21 @@
+<?php declare(strict_types=1);
+
+/*
+ * This file is part of Packagist.
+ *
+ * (c) Jordi Boggiano <j.boggiano@seld.be>
+ *     Nils Adermann <naderman@naderman.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Validator\Constraints;
+
+use Symfony\Component\Validator\Constraint;
+
+#[\Attribute]
+class TransferPackageValidMaintainersList extends Constraint
+{
+    public string $emptyMessage = 'At least one maintainer must be specified.';
+}

src/Validator/Constraints/TransferPackageValidMaintainersListValidator.php

@@ -0,0 +1,46 @@
+<?php declare(strict_types=1);
+
+/*
+ * This file is part of Packagist.
+ *
+ * (c) Jordi Boggiano <j.boggiano@seld.be>
+ *     Nils Adermann <naderman@naderman.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Validator\Constraints;
+
+use App\Entity\User;
+use App\Form\Model\InvalidMaintainer;
+use Doctrine\Common\Collections\Collection;
+use Symfony\Component\Validator\Constraint;
+use Symfony\Component\Validator\ConstraintValidator;
+use Symfony\Component\Validator\Exception\UnexpectedTypeException;
+use Symfony\Component\Validator\Exception\UnexpectedValueException;
+
+class TransferPackageValidMaintainersListValidator extends ConstraintValidator
+{
+    public function validate(mixed $value, Constraint $constraint): void
+    {
+        if (!$constraint instanceof TransferPackageValidMaintainersList) {
+            throw new UnexpectedTypeException($constraint, TransferPackageValidMaintainersList::class);
+        }
+
+        if (null === $value) {
+            return;
+        }
+
+        if (!$value instanceof Collection) {
+            throw new UnexpectedValueException($value, Collection::class);
+        }
+
+        if (!$value->isEmpty()) {
+            return;
+        }
+
+        $this->context->buildViolation($constraint->emptyMessage)
+            ->addViolation();
+    }
+}