Skip to content

Commit 585116d

Browse files
committed
use emsdk's node
1 parent 3f69737 commit 585116d

File tree

4 files changed

+3
-15
lines changed

4 files changed

+3
-15
lines changed

.github/workflows/deploy-github-page.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ jobs:
5656
echo "PREFIX=$PREFIX" >> $GITHUB_ENV
5757
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot
5858
59-
micromamba create -n node-env -c conda-forge nodejs=22
60-
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
61-
6259
emcmake cmake \
6360
-DCMAKE_BUILD_TYPE=Release \
6461
-DCMAKE_INSTALL_PREFIX=$PREFIX \

CONTRIBUTING.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ micromamba create -f environment-wasm-build.yml -y
7171
micromamba activate xeus-cpp-wasm-build
7272
```
7373

74-
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Prefer using node 22 and above as prior versions lead to flaky test runs. Once the test pass, run the install command.
74+
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Once the test pass, run the install command.
7575

7676
```bash
7777
micromamba create -f environment-wasm-host.yml --platform=emscripten-wasm32
@@ -81,9 +81,6 @@ export BUILD_PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-build
8181
export PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-host
8282
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot
8383

84-
micromamba create -n node-env -c conda-forge nodejs=22
85-
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
86-
8784
emcmake cmake \
8885
-DCMAKE_BUILD_TYPE=Release \
8986
-DCMAKE_INSTALL_PREFIX=$PREFIX \

README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ micromamba create -f environment-wasm-build.yml -y
8888
micromamba activate xeus-cpp-wasm-build
8989
```
9090

91-
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Prefer using node 22 and above as prior versions lead to flaky test runs. Once the test pass, run the install command.
91+
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Once the test pass, run the install command.
9292
```bash
9393
micromamba create -f environment-wasm-host.yml --platform=emscripten-wasm32
9494
mkdir build
@@ -97,9 +97,6 @@ export BUILD_PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-build
9797
export PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-host
9898
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot
9999

100-
micromamba create -n node-env -c conda-forge nodejs=22
101-
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
102-
103100
emcmake cmake \
104101
-DCMAKE_BUILD_TYPE=Release \
105102
-DCMAKE_INSTALL_PREFIX=$PREFIX \

docs/source/InstallationAndUsage.rst

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ the following
6666
micromamba create -f environment-wasm-build.yml -y
6767
micromamba activate xeus-cpp-wasm-build
6868
69-
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Prefer using node 22 and above as prior versions lead to flaky test runs. Once the test pass, run the install command.
69+
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Once the test pass, run the install command.
7070

7171
.. code-block:: bash
7272
@@ -77,9 +77,6 @@ You are now in a position to build the xeus-cpp kernel. You build and test it in
7777
export PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-host
7878
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot
7979
80-
micromamba create -n node-env -c conda-forge nodejs=22
81-
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
82-
8380
emcmake cmake \
8481
-DCMAKE_BUILD_TYPE=Release \
8582
-DCMAKE_INSTALL_PREFIX=$PREFIX \

0 commit comments

Comments
 (0)