Skip to content

Commit 7b8fbc2

Browse files
authored
Remove commented out code and associated strings (#6475)
As I was documenting undocumented strings (see #6457), I noticed that two messages are only used once in a few lines of code that were commented out in 2023. To clean up the messages, I am removing them from the strings list and deleting the commented-out code.
1 parent 30d1107 commit 7b8fbc2

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.kt

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -153,21 +153,7 @@ after opening the app.
153153
}
154154
}
155155
setUpPager()
156-
/**
157-
* Ask the user for media location access just after login
158-
* so that location in the EXIF metadata of the images shared by the user
159-
* is retained on devices running Android 10 or above
160-
*/
161-
// if (VERSION.SDK_INT >= VERSION_CODES.Q) {
162-
// ActivityCompat.requestPermissions(this,
163-
// new String[]{Manifest.permission.ACCESS_MEDIA_LOCATION}, 0);
164-
// PermissionUtils.checkPermissionsAndPerformAction(
165-
// this,
166-
// () -> {},
167-
// R.string.media_location_permission_denied,
168-
// R.string.add_location_manually,
169-
// permission.ACCESS_MEDIA_LOCATION);
170-
// }
156+
171157
checkAndResumeStuckUploads()
172158
}
173159
}

app/src/main/res/values/strings.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -551,9 +551,6 @@ Upload your first media by tapping on the add button.</string>
551551
<string name="exif_tag_name_serialNumbers">Serial Numbers</string>
552552
<string name="exif_tag_name_software">Software</string>
553553

554-
<string name="media_location_permission_denied">Media location access denied</string>
555-
<string name="add_location_manually">We may not be able to automatically obtain location data from pictures you upload. Please add the appropriate location for each picture before submitting</string>
556-
557554
<string name="share_text">Upload photos to Wikimedia Commons directly from your phone. Download the Commons App now: %1$s</string>
558555
<string name="share_via">Share app via...</string>
559556
<string name="image_info">Image Info</string>

0 commit comments

Comments
 (0)