Add Firefox and Safari to Selenium CI suite

Author: codingjoe

.github/workflows/ci.yml

@@ -64,19 +64,19 @@ jobs:
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           flags: python-${{ matrix.python-version }}
-  Selenium:
+  selenium:
     needs:
-      - standardjs
-    runs-on: ubuntu-latest
+      - PyTest
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v6
-      - name: Install Selenium
-        run: |
-          curl -LsSfO https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
-          sudo dpkg -i google-chrome-stable_current_amd64.deb || sudo apt-get -f install -y
       - uses: astral-sh/setup-uv@v7
       - run: uv run pytest -m selenium
       - uses: codecov/codecov-action@v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-          flags: selenium
+          flags: selenium-${{ matrix.os }}

tests/conftest.py

@@ -25,12 +25,12 @@ def random_name(n):
     return "-".join([x.capitalize() for x in words])
 
 
-@pytest.fixture(scope="session")
-def driver():
-    chrome_options = webdriver.ChromeOptions()
-    chrome_options.add_argument("--headless=new")
+@pytest.fixture(scope="session", params=["Chrome", "Safari", "Firefox"])
+def driver(request):
+    options = getattr(webdriver, f"{request.param}Options")()
+    options.add_argument("--headless")
     try:
-        b = webdriver.Chrome(options=chrome_options)
+        b = getattr(webdriver, request.param)(options=options)
     except WebDriverException as e:
         pytest.skip(str(e))
     else:

tests/test_forms.py

@@ -701,12 +701,11 @@ def test_widgets_selected_after_validation_error(
 
         # clicking city select2 lists all available cities
         city_container.click()
-        WebDriverWait(driver, 60).until(
-            expected_conditions.presence_of_element_located(
+        city_options = WebDriverWait(driver, 60).until(
+            expected_conditions.visibility_of_all_elements_located(
                 (By.CSS_SELECTOR, ".select2-results li")
             )
         )
-        city_options = driver.find_elements(By.CSS_SELECTOR, ".select2-results li")
         city_names_from_browser = {option.text for option in city_options}
         city_names_from_db = set(City.objects.values_list("name", flat=True))
         assert len(city_names_from_browser) == City.objects.count()
@@ -751,12 +750,11 @@ def test_widgets_selected_after_validation_error(
 
         # clicking country select2 lists reduced list to the only country available to the city
         country_container.click()
-        WebDriverWait(driver, 60).until(
-            expected_conditions.presence_of_element_located(
+        country_options = WebDriverWait(driver, 60).until(
+            expected_conditions.presence_of_all_elements_located(
                 (By.CSS_SELECTOR, ".select2-results li")
             )
         )
-        country_options = driver.find_elements(By.CSS_SELECTOR, ".select2-results li")
         country_names_from_browser = {option.text for option in country_options}
         country_names_from_db = {City.objects.get(name=city_name).country.name}
         assert len(country_names_from_browser) != Country.objects.count()
@@ -820,7 +818,7 @@ def test_dependent_fields_clear_after_change_parent(
         # check the value in city2
         city2_container.click()
         WebDriverWait(driver, 60).until(
-            expected_conditions.presence_of_element_located(
+            expected_conditions.visibility_of_all_elements_located(
                 (By.CSS_SELECTOR, ".select2-results li")
             )
         )