Skip to content

Commit fda6edf

Browse files
author
investing-algorithms
authored
Merge pull request #22 from investing-algorithms/hotfix_manifest
Hotfix manifest
2 parents 0678a78 + f8b3874 commit fda6edf

27 files changed

+94
-142
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,19 @@
22

33
## Contribute to the value investing bot
44

5-
Feel like our bot is missing a feature? We welcome your pull requests!
5+
Feel like the framework is missing a feature or can be fixed? We welcome your pull requests!
66

77
Few pointers for contributions:
88

9-
- Create your PR against the `develop` branch, not `master`.
9+
- Create your branch against the `develop` branch, not `master`.
1010
- New features need to contain unit tests and must be PEP8 conformant (max-line-length = 100).
1111
- Creating a feature, must be done on a branch with prefix `feature_`.
1212
- Making a hotfix, must be done on a branch with prefix `hotfix_`.
1313

14-
If you are unsure, discuss the feature on our [Slack](https://join.slack.com/t/investingbots/shared_invite/enQtODgwNTg3MzA2MjYyLTdiZjczZDRlNWJjNDdmYThiMGE0MzFhOTg4Y2E0NzQ2OTgxYjA1NzU3ZWJiY2JhOTE1ZGJlZGFiNDU3OTAzMDg)
14+
If you are unsure, discuss the feature or hotfix on our [Slack](https://inv-algo-framework.slack.com)
1515
or in a [issue](https://github.com/investingbots/value-investing-bot/issues) before a PR.
1616

17-
## Getting started
18-
19-
## Before sending the PR:
17+
## Rules
2018

2119
### 1. Run unit tests
2220

@@ -46,55 +44,22 @@ pytest tests/test_<file_name>.py::test_<method_name>
4644
#### Run Flake8
4745

4846
```bash
49-
flake8 bot
47+
flake8 investing_algorithm_framework
5048
```
5149

52-
We receive a lot of code that fails the `flake8` checks.
53-
To help with that, we encourage you to install the git pre-commit
54-
hook that will warn you when you try to commit code that fails these checks.
55-
Guide for installing them is [here](http://flake8.pycqa.org/en/latest/user/using-hooks.html).
56-
5750
### 3. Test if all type-hints are correct
5851

5952
#### Run mypy
6053

6154
``` bash
62-
mypy bot
55+
mypy investing_algorithm_framework
6356
```
6457

65-
## (Core)-Committer Guide
66-
67-
### Process: Pull Requests
68-
69-
How to prioritize pull requests, from most to least important:
70-
71-
1. Fixes for broken tests. Broken means broken on any supported platform or Python version.
72-
1. Extra tests to cover corner cases.
73-
1. Minor edits to docs.
74-
1. Bug fixes.
75-
1. Major edits to docs.
76-
1. Features.
77-
78-
Ensure that each pull request meets all requirements in the Contributing document.
79-
80-
### Process: Issues
81-
82-
If an issue is a bug that needs an urgent fix, mark it for the next patch release.
83-
Then either fix it or mark as please-help.
84-
85-
For other issues: encourage friendly discussion, moderate debate, offer your thoughts.
86-
8758
### Process: Your own code changes
8859

8960
All code changes, regardless of who does them, need to be reviewed and merged by someone else.
9061
This rule applies to all the core committers.
9162

92-
Exceptions:
93-
94-
- Minor corrections and fixes to pull requests submitted by others.
95-
- While making a formal release, the release manager can make necessary, appropriate changes.
96-
- Small documentation changes that reinforce existing subject matter. Most commonly being, but not limited to spelling and grammar corrections.
97-
9863
### Responsibilities
9964

10065
- Ensure cross-platform compatibility for every change that's accepted. Windows, Mac & Linux.
@@ -107,11 +72,14 @@ Exceptions:
10772

10873
Contributors may be given commit privileges. Preference will be given to those with:
10974

110-
1. Past contributions to value investing btot and other related open-source projects. Contributions to value investing bot include both code (both accepted and pending) and friendly participation in the issue tracker and Pull request reviews. Quantity and quality are considered.
75+
1. Past contributions to value investing algorithm framework and other related open-source projects.
76+
Contributions to value for the framework include both code (both accepted and pending) and friendly participation in the issue tracker and Pull request reviews. Quantity and quality are considered.
11177
1. A coding style that the other core committers find simple, minimal, and clean.
11278
1. Access to resources for cross-platform development and testing.
11379
1. Time to devote to the project regularly.
11480

115-
Being a Committer does not grant write permission on `develop` or `master` for security reasons (Users trust the value investing bot with their Exchange API keys).
81+
Being a Committer does not grant write permission on `develop` or `master` for security reasons (Users trust the investing algorithm framework with their financial secrets).
82+
83+
### Help
11684

117-
After being Committer for some time, a Committer may be named Core Committer and given full repository access.
85+
If you want help, or not sure on how to become a committer for the project, feel free to sent an email to: investing.algorithm.framework@gmail.com

INSTALL

Lines changed: 0 additions & 6 deletions
This file was deleted.

INSTALL.md

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
# Installation
2+
3+
4+
### Install Python
5+
Being a Python framework, it requires Python. Python includes a lightweight database called
6+
SQLite that the framework can use so you won’t need to set up a database just yet.
7+
8+
As of now, the framework only works with python 3.x.
9+
10+
### Python pip install (recommended)
11+
12+
You can easily use pip to install the framework in your python environment.
13+
14+
```sh
15+
$ pip install investing-algorithm-framework
16+
```
17+
18+
### Installation from source
19+
20+
First clone the repository
21+
```sh
22+
$ git clone https://github.com/investing-algorithms/investing-algorithm-framework.git
23+
```
24+
25+
Then install the framework by running:
26+
```sh
27+
$ pip install <path to cloned investing-algorithm-framework>
28+
```
29+
30+
### Verifying the installation
31+
32+
To verify that you correctly installed the framework, type python from your shell. Then at the Python prompt,
33+
try to import investing-algorithm-framework:
34+
35+
```python
36+
import investing-algorithm-framework
37+
print(investing-algorithm-framework.get_version())
38+
```
39+

MANIFEST.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
graft investing_bot_framework
1+
graft investing_algorithm_framework
22
include AUTHORS
33
include INSTALL
44
include LICENSE

README.md

Lines changed: 21 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -2,97 +2,48 @@
22

33
# Investing Algorithm Framework
44

5-
The Investing Algorithm Framework is a free and open source Python framework that encourages rapid development and clean,
6-
pragmatic design.
5+
The Investing Algorithm Framework is a python framework to build investment algorithms. It encourages rapid development and clean,
6+
pragmatic design. It is free for personal usage and open source.
77

8-
The goal is to give you a configurable investing algorithm where you can decide how you implement your data providers,
9-
strategies, and order executors.
8+
In most cases, you'll probably never have to change code on this repo directly if you are building your algorithm/bot. But if you do, check out CONTRIBUTING.md
109

11-
#####Disclaimer
12-
If you use this framework for your investments, do not risk money which you are afraid to lose. We can't stress this
13-
enough:
10+
If you'd like to chat with investing-algorithm-framework users and developers, [join us on Slack](https://inv-algo-framework.slack.com)
1411

15-
BEFORE YOU START USING MONEY WITH THE FRAMEWORK, MAKE SURE THAT YOU TESTED YOUR COMPONENTS THOROUGHLY. USE THE SOFTWARE AT
12+
#### Disclaimer
13+
If you use this framework for your investments, do not risk money which you are afraid to lose. We can't stress this
14+
enough:
15+
16+
BEFORE YOU START USING MONEY WITH THE FRAMEWORK, MAKE SURE THAT YOU TESTED YOUR COMPONENTS THOROUGHLY. USE THE SOFTWARE AT
1617
YOUR OWN RISK. THE AUTHORS AND ALL AFFILIATES ASSUME NO RESPONSIBILITY FOR YOUR INVESTMENT RESULTS.
1718

18-
Also, make sure that you read the source code of any plugin you use or implementation of an algorithm made with this
19+
Also, make sure that you read the source code of any plugin you use or implementation of an algorithm made with this
1920
framework.
2021

21-
Documentation
22-
------
23-
All documentation is in the "docs" directory and online at "". If you're just getting started, here's how we recommend
24-
you read the docs:
25-
26-
* First, read install for instructions on installing Investing Algorithm Framework.
27-
* Next, work through the tutorials in order. ("Quickstart", "Template algorithm", "Custom algorithm").
28-
* For concrete algorithm examples you probably want to read through the topical guides.
29-
30-
31-
## Development branches
32-
33-
The project is currently setup in two main branches:
34-
35-
- `develop` - This branch has often new features, but might also cause breaking changes.
36-
- `master` - This branch contains the latest stable release. The bot 'should' be stable on this branch, and is generally well tested.
37-
- `feature/*` - These are feature branches, which are being worked on heavily. Please don't use these unless you want to test a specific feature.
38-
- `hotfix/*` - These are hot fix branches, which are being worked on heavily. Please don't use these unless you really need to.
39-
22+
## Documentation
23+
All documentation can be found online at "".
4024

4125
### Help / Slack
4226

4327
For any questions not covered by the documentation or for further
44-
information about the bot, we encourage you to join our slack channel.
28+
information about the framework, we encourage you to join our slack channel.
4529

46-
[Slack](https://join.slack.com/t/investingbots/shared_invite/enQtODgwNTg3MzA2MjYyLTdiZjczZDRlNWJjNDdmYThiMGE0MzFhOTg4Y2E0NzQ2OTgxYjA1NzU3ZWJiY2JhOTE1ZGJlZGFiNDU3OTAzMDg)
30+
[join us on Slack](https://inv-algo-framework.slack.com)
4731

4832
### [Bugs / Issues](https://github.com/investingbots/value-investing-bot/issues?q=is%3Aissue)
4933

5034
If you discover a bug in the bot, please
51-
[search our issue tracker](https://github.com/investingbots/value-investing-bot/issues?q=is%3Aissue)
35+
[search our issue tracker](https://github.com/investing-algorithms/investing-algorithm-framework/issues?q=is%3Aissue)
5236
first. If it hasn't been reported, please
53-
[create a new issue](https://github.com/investingbots/value-investing-bot/issues/new) and
54-
ensure you follow the template guide so that our team can assist you as
55-
quickly as possible.
56-
57-
### [Feature Requests](https://github.com/investingbots/value-investing-bot/labels/enhancement)
58-
59-
Have you a great idea to improve the bot you want to share? Please,
60-
first search if this feature was not [already discussed](https://github.com/investingbots/value-investing-bot/labels/enhancement).
61-
If it hasn't been requested, please
62-
[create a new request](https://github.com/investingbots/value-investing-bot/new)
63-
and ensure you follow the template guide so that it does not get lost
64-
in the bug reports.
65-
66-
### [Pull Requests](https://github.com/investingbots/value-investing-bot/pulls)
37+
[create a new issue](https://github.com/investing-algorithms/investing-algorithm-framework/issues/new) and
38+
ensure you follow the template guide so that developers can assist you as quickly as possible.
6739

68-
Feel like our bot is missing a feature? We welcome your pull requests!
40+
Feel like the framework is missing a feature? We welcome your pull requests!
6941

7042
Please read our
71-
[Contributing document](https://github.com/investingbots/value-investing-bot/blob/develop/CONTRIBUTING.md)
43+
[Contributing document](https://github.com/investing-algorithms/investing-algorithm-framework/blob/master/CONTRIBUTING.md)
7244
to understand the requirements before sending your pull-requests.
7345

74-
**Note** before starting any major new feature work, *please open an issue describing what you are planning to do* or talk to us on [Slack](https://join.slack.com/t/investingbots/shared_invite/enQtODgwNTg3MzA2MjYyLTdiZjczZDRlNWJjNDdmYThiMGE0MzFhOTg4Y2E0NzQ2OTgxYjA1NzU3ZWJiY2JhOTE1ZGJlZGFiNDU3OTAzMDg).
46+
**Note** before starting any major new feature work, *please open an issue describing what you are planning to do* or talk to us on [Slack](https://join.slack.com/t/investingbots/shared_invite/enQtODgwNTg3MzA2MjYyLTdiZjczZDRlNWJjNDdmYThiMGE0MzFhOTg4Y2E0NzQ2OTgxYjA1NzU3ZWJiY2JhOTE1ZGJlZGFiNDU3OTAzMDg).
7547
This will ensure that interested parties can give valuable feedback on the feature, and let others know that you are working on it.
7648

77-
**Important:** Always create your PR against the `develop` branch, not `master`.
78-
79-
## Requirements
80-
81-
### Uptodate clock
82-
The clock must be accurate, syncronized to a NTP server very frequently to avoid problems with communication to the exchanges.
83-
84-
### Min hardware required
85-
86-
To run this bot we recommend you a cloud instance with a minimum of:
87-
88-
- Minimal (advised) system requirements: 2GB RAM, 1GB disk space, 2vCPU
89-
90-
In the future raspberry pi support will be added.
91-
92-
### Software requirements
93-
94-
- [Python 3.6.x](http://docs.python-guide.org/en/latest/starting/installation/)
95-
- [pip](https://pip.pypa.io/en/stable/installing/)
96-
- [git](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)
97-
- [virtualenv](https://virtualenv.pypa.io/en/stable/installation/) (Recommended)
98-
- [Docker](https://www.docker.com/products/docker) (Recommended)
49+
**Important:** Always create your feature or hotfix against the `develop` branch, not `master`.

investing_algorithm_framework/bin/investing-algorithm-framework-admin renamed to bin/investing-algorithm-framework-admin

File renamed without changes.

ci/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#!/bin/sh
22

3-
python3 -m unittest discover -s ../
3+
pytest ../.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
from investing_algorithm_framework.utils.version import get_version
22

3-
VERSION = (1, 0, 0, 'alpha', 0)
3+
VERSION = (0, 1, 0, 'alpha', 0)
44

investing_algorithm_framework/tests/resources/__init__.py

Lines changed: 0 additions & 13 deletions
This file was deleted.

investing_algorithm_framework/tests/utils/__init__.py

Whitespace-only changes.

0 commit comments

Comments
 (0)