Remove list of workers

Removing the member attribute that kept a list of workers.

This attribute was redundant

Author: DUYN

bot/executors/executor.py

@@ -24,21 +24,22 @@ def __init__(self,  max_workers: int = DEFAULT_MAX_WORKERS):
 
         self._max_workers = max_workers
         self._pending_workers: Queue = None
-        self._running_workers: List[Worker] = []
         self._running_threads: Dict[Worker, StoppableThread] = {}
 
     def start(self) -> None:
         """
         Main entry for the executor.
         """
+
         self._initialize()
         self.run_jobs()
 
     def stop(self) -> None:
         """
         Function that will stop all running workers.
         """
-        for worker in self._running_workers:
+
+        for worker in self._running_threads:
             self.stop_running_worker(worker)
 
         self.clean_up()
@@ -47,14 +48,15 @@ def clean_up(self):
         """
         Clean ups the resources.
         """
+
         self._pending_workers: Queue = None
-        self._running_workers: List[Worker] = []
         self._running_threads: Dict[Worker, StoppableThread] = {}
 
     def _initialize(self):
         """
         Functions that initializes the pending workers.
         """
+
         workers = self.create_workers()
 
         if not workers or len(workers) == 0:
@@ -74,17 +76,17 @@ def create_workers(self) -> List[Worker]:
 
     def run_jobs(self) -> None:
         """
-        Will start all the workers.
+        Function that will start all the workers.
         """
-        worker_iteration = self._max_workers - len(self._running_workers)
+
+        worker_iteration = self._max_workers - len(self._running_threads.keys())
 
         while worker_iteration > 0 and not self._pending_workers.empty():
             worker = self._pending_workers.get()
             worker_iteration -= 1
             thread = StoppableThread(target=worker.start)
             worker.add_observer(self)
             self._running_threads[worker] = thread
-            self._running_workers.append(worker)
             thread.start()
 
     @synchronized
@@ -93,8 +95,8 @@ def update(self, observable, **kwargs) -> None:
         Observer implementation.
         """
 
-        if observable in self._running_workers:
-            self._running_workers.remove(observable)
+        if observable in self._running_threads:
+            del self._running_threads[observable]
 
         if not self.processing:
             self.notify_observers()
@@ -105,6 +107,7 @@ def stop_running_worker(self, worker: Worker) -> None:
         """
         Function that will stop a running worker.
         """
+
         thread = self._running_threads[worker]
         thread.kill()
 
@@ -121,4 +124,4 @@ def processing(self) -> bool:
         """
 
         return (self._pending_workers is not None and not self._pending_workers.empty()) or \
-               (self._running_workers is not None and len(self._running_workers) > 0)
+               (self._running_threads is not None and len(self._running_threads.keys()) > 0)