Add check for add of tickers

Author: DUYN

bot/bot.py

@@ -5,7 +5,6 @@
 from bot.data import remove_ticker, get_tickers, add_ticker, get_company_profile
 from bot import __version__, OperationalException
 from bot.data.data_provider_manager import DataProviderManager
-from bot.data.data_providers import DataProviderException
 
 logger = logging.getLogger(__name__)
 
@@ -30,31 +29,36 @@ def add_ticker(self, ticker: str) -> None:
         logger.info("Adding ticker ...")
 
         if not get_company_profile(ticker, self.config):
-            profile = self.__data_provider_manager.get_profile(ticker)
 
-            if not profile:
-                raise OperationalException("Could not evaluate {} with the data providers".format(ticker))
+            if self.__data_provider_manager.evaluate_ticker(ticker):
 
-            company_name = profile.get('profile', {}).get('companyName', None)
-            category = profile.get('profile', {}).get('industry', None)
+                profile = self.__data_provider_manager.get_profile(ticker)
 
-            if not company_name:
-                raise OperationalException("Could not evaluate company name for ticker {} with the data providers")
+                if not profile:
+                    raise OperationalException("Could not evaluate {} with the data providers".format(ticker))
 
-            if not company_name:
-                raise OperationalException("Could not evaluate category for ticker {} with the data providers")
+                company_name = profile.get('profile', {}).get('companyName', None)
+                category = profile.get('profile', {}).get('industry', None)
 
-            try:
-                add_ticker(
-                    ticker,
-                    company_name=company_name,
-                    category=category,
-                    config=self.config
-                )
-            except Exception:
-                raise OperationalException(
-                    "Something went wrong with adding ticker {} to the registry".format(ticker)
-                )
+                if not company_name:
+                    raise OperationalException("Could not evaluate company name for ticker {} with the data providers")
+
+                if not company_name:
+                    raise OperationalException("Could not evaluate category for ticker {} with the data providers")
+
+                try:
+                    add_ticker(
+                        ticker,
+                        company_name=company_name,
+                        category=category,
+                        config=self.config
+                    )
+                except Exception:
+                    raise OperationalException(
+                        "Something went wrong with adding ticker {} to the registry".format(ticker)
+                    )
+            else:
+                raise OperationalException("Could not evaluate ticker {} with the data providers".format(ticker))
         else:
             raise OperationalException(
                 "Ticker {} is already present in registry".format(ticker)

bot/data/data_providers/fmp_data_provider.py

@@ -1,9 +1,9 @@
 import logging
 import json
-from enum import Enum
 from typing import Dict, Any
 
 from urllib.request import urlopen
+from urllib import error
 
 from bot.data.data_providers.data_provider import DataProvider, DataProviderException
 
@@ -32,8 +32,10 @@ def evaluate_ticker(self, ticker: str) -> bool:
             response = urlopen(url)
             data = response.read().decode("utf-8")
             data = json.loads(data)
-            logger.info(data)
             return data['symbol'] == ticker
+        except error.HTTPError:
+            logger.info('Hello')
+            return False
         except Exception:
             return False