Skip to content

Commit 3e3ac64

Browse files
committed
Only test error messages in ValidationMessageTest
1 parent 0154eac commit 3e3ac64

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

tests/UniqueTranslationTest.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public function it_checks_if_the_translation_for_the_current_locale_is_unique()
3232
], $rules);
3333

3434
$this->assertTrue($validation->fails());
35-
$this->assertEquals(['slug', 'slug.en', 'name', 'name.en'], $validation->errors()->keys());
3635

3736
// The following validation passes, because the
3837
// current locale is "en", so we actually set
@@ -44,7 +43,6 @@ public function it_checks_if_the_translation_for_the_current_locale_is_unique()
4443
], $rules);
4544

4645
$this->assertTrue($validation->passes());
47-
$this->assertEmpty($validation->errors()->keys());
4846
}
4947

5048
/** @test */
@@ -66,7 +64,6 @@ public function it_checks_if_the_translation_for_a_specific_locale_is_unique()
6664
], $rules);
6765

6866
$this->assertTrue($validation->fails());
69-
$this->assertEquals(['slug', 'slug.en', 'name', 'name.en'], $validation->errors()->keys());
7067

7168
$validation = Validator::make([
7269
'slug' => ['en' => 'different-slug-en'],
@@ -82,15 +79,13 @@ public function it_checks_if_the_translation_for_a_specific_locale_is_unique()
8279
], $rules);
8380

8481
$this->assertTrue($validation->fails());
85-
$this->assertEquals(['slug', 'slug.nl', 'name', 'name.nl'], $validation->errors()->keys());
8682

8783
$validation = Validator::make([
8884
'slug' => ['nl' => 'different-slug-en'],
8985
'name' => ['nl' => 'different-name-en'],
9086
], $rules);
9187

9288
$this->assertTrue($validation->passes());
93-
$this->assertEmpty($validation->errors()->keys());
9489
}
9590

9691
/** @test */
@@ -114,15 +109,13 @@ public function a_database_connection_can_be_specified()
114109
], $rules);
115110

116111
$this->assertTrue($validation->fails());
117-
$this->assertEquals(['slug', 'slug.en', 'name', 'name.en'], $validation->errors()->keys());
118112

119113
$validation = Validator::make([
120114
'slug' => 'different-slug-en',
121115
'name' => 'different-name-en',
122116
], $rules);
123117

124118
$this->assertTrue($validation->passes());
125-
$this->assertEmpty($validation->errors()->keys());
126119
}
127120

128121
/** @test */
@@ -144,7 +137,6 @@ public function the_models_attribute_name_can_be_specified()
144137
], $rules);
145138

146139
$this->assertTrue($validation->fails());
147-
$this->assertEquals(['form_slug', 'form_slug.en', 'form_name', 'form_name.en'], $validation->errors()->keys());
148140

149141
$rules = [
150142
'form_slug.*' => "{$this->rule}:{$this->table},slug",
@@ -157,7 +149,6 @@ public function the_models_attribute_name_can_be_specified()
157149
], $rules);
158150

159151
$this->assertTrue($validation->fails());
160-
$this->assertEquals(['form_slug', 'form_slug.nl', 'form_name', 'form_name.nl'], $validation->errors()->keys());
161152
}
162153

163154
/** @test */
@@ -179,7 +170,6 @@ public function it_ignores_the_given_id()
179170
], $rules);
180171

181172
$this->assertTrue($validation->passes());
182-
$this->assertEmpty($validation->errors()->keys());
183173

184174
$rules = [
185175
'slug.*' => "{$this->rule}:{$this->table},null,{$model->id}",
@@ -192,7 +182,6 @@ public function it_ignores_the_given_id()
192182
], $rules);
193183

194184
$this->assertTrue($validation->passes());
195-
$this->assertEmpty($validation->errors()->keys());
196185
}
197186

198187
/** @test */
@@ -215,7 +204,6 @@ public function it_ignores_a_specific_attribute_with_the_given_value()
215204
], $rules);
216205

217206
$this->assertTrue($validation->passes());
218-
$this->assertEmpty($validation->errors()->keys());
219207

220208
$rules = [
221209
'slug.*' => "{$this->rule}:{$this->table},null,{$model->other_field},other_field",
@@ -228,7 +216,6 @@ public function it_ignores_a_specific_attribute_with_the_given_value()
228216
], $rules);
229217

230218
$this->assertTrue($validation->passes());
231-
$this->assertEmpty($validation->errors()->keys());
232219
}
233220

234221
/** @test */
@@ -250,6 +237,5 @@ public function it_ignores_null_values()
250237
], $rules);
251238

252239
$this->assertTrue($validation->passes());
253-
$this->assertEmpty($validation->errors()->keys());
254240
}
255241
}

tests/WhereClauseTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ public function it_accepts_where_clause()
4040
], $rules);
4141

4242
$this->assertTrue($validation->passes());
43-
$this->assertEmpty($validation->errors()->keys());
4443
}
4544

4645
/** @test */
@@ -63,7 +62,6 @@ public function it_accepts_where_not_clauses()
6362
], $rules);
6463

6564
$this->assertTrue($validation->passes());
66-
$this->assertEmpty($validation->errors()->keys());
6765
}
6866

6967
/** @test */
@@ -86,7 +84,6 @@ public function it_accepts_where_null_clause()
8684
], $rules);
8785

8886
$this->assertTrue($validation->passes());
89-
$this->assertEmpty($validation->errors()->keys());
9087
}
9188

9289
/** @test */
@@ -109,6 +106,5 @@ public function it_accepts_where_not_null_clause()
109106
], $rules);
110107

111108
$this->assertTrue($validation->passes());
112-
$this->assertEmpty($validation->errors()->keys());
113109
}
114110
}

0 commit comments

Comments
 (0)