🤖 refactor: replace native UI elements with shadcn components #936
+643
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update components.json to use browser/components paths - Add shadcn context-menu, select, and dialog primitives - Update dialog.tsx with app-consistent styling (bg-dark, borders) - Update select.tsx with compact sizing and theme colors - Update button.tsx variants to use accent colors - Replace native <select> with shadcn Select in: - ThemeSelector, GeneralSection, ModelsSection - Create Select wrapper maintaining existing API - Replace native <button> with shadcn Button in: - Modal (CancelButton, PrimaryButton, DangerButton now wrap Button) - SettingsModal, ProvidersSection, ModelRow - ProjectCreateModal, SettingsButton, WorkspaceHeader _Generated with `mux`_
kylecarbs
force-pushed
the
refactor/shadcn-ui-components
branch
from
ab8aed3 to
2db79af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces shadcn UI components and refactors existing UI elements to use them for consistent styling and better accessibility.
Changes
New shadcn components:
context-menu.tsx- Context menu primitive styled with app colorsdialog.tsx- Dialog primitive with app-consistent stylingselect.tsx- Select primitive with compact sizingComponent updates:
button.tsx- Updated variants to use accent colors as primarycomponents.json- Updated paths for browser/componentsRefactored to use shadcn:
Notes
Selectcomponent wrapper maintains the existing API for easy migrationGenerated with
mux