Reviews

Author: Chris Maunder

src/SDK/Python/src/codeproject_ai_sdk/utils/__init__.py

@@ -1,5 +1,2 @@
 from .cpuinfo import CPUInfoBase, LinuxCPUInfo, IRIXCPUInfo, DarwinCPUInfo, NetBSDCPUInfo, SunOSCPUInfo, Win32CPUInfo
 #from .environment_check import check_requirements, check_is_file, get_arguments
-
-# REVIEW: These probably not needed at this time
-# from .image_utils import rotate_image, deskew, compute_skew

src/server/Controllers/ProxyController.cs

@@ -572,13 +572,10 @@ private async Task<RequestPayload> CreatePayload(string pathSuffix, RouteQueueIn
                     queryParams.Add(new KeyValuePair<string, string?[]>(param.Key, param.Value.ToArray()));
             }
 
-            // REVIEW: [Chris] This is where we would need to handle a JSON request body. We would
-            //         need to read the request body and parse it as JSON. We would then need to
-            //         use the JSON object to populate the payload.
-
-            // The HasFormContentType check should be sufficient and checks for multipart/form-data,
-            // and application/x-www-form-urlencoded. There should be no need to use a try/catch
-            // here either, but the GetFileData() method might throw if the moon is in the wrong phase.
+            // We first check if the request is in JSON form. The HasFormContentType check should be
+            // sufficient since it checks for multipart/form-data and application/x-www-form-urlencoded.
+            // There should be no need to use a try/catch here either, but the GetFileData() method
+            // might throw if the moon is in the wrong phase.
             if (Request.HasJsonContentType() && Request.ContentLength > 0)
             {
                 var payload = await Request.ReadFromJsonAsync<RequestPayload>() ?? new RequestPayload();

src/server/Controllers/QueueController.cs

@@ -146,7 +146,7 @@ public async Task<ObjectResult> SetResponse(string reqid)
         /// <param name="moduleId">The id of the request the response is for.</param>
         /// <param name="statusData"></param>
         /// <returns>The Request Object.</returns>
-        // REVIEW: Possible rename this to BackendController and map both /vi/queue and /v1/backend
+        // TODO: Possible rename this to BackendController and map both /vi/queue and /v1/backend
         //         to maintain backwards compatibility for the modules.
         [HttpPost("updatemodulestatus/{moduleId}", Name = "UpdateModuleStatusData")]
         [ProducesResponseType(StatusCodes.Status200OK)]