Skip to content

Commit 4ddeda4

Browse files
authored
Merge pull request #226 from codeitcodes/409-fix
409 fix
2 parents 77b76d2 + 545d6a9 commit 4ddeda4

File tree

4 files changed

+58
-9
lines changed

4 files changed

+58
-9
lines changed

filebrowser.js

Lines changed: 46 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -560,6 +560,8 @@ async function renderSidebarHTML() {
560560
}
561561

562562

563+
protectModFileInSidebar(file.sha, file.name);
564+
563565
// add modified flag to file
564566
let modified = '';
565567
if (modifiedFiles[file.sha] &&
@@ -1317,6 +1319,20 @@ async function loadFileInHTML(fileEl, fileSha) {
13171319
}
13181320

13191321

1322+
const fileName = fileEl.querySelector('.name').textContent.replaceAll('\n','');
1323+
1324+
protectModFileInSidebar(fileSha, fileName);
1325+
1326+
// if file is modified
1327+
if (modifiedFiles[fileSha] && !modifiedFiles[fileSha].eclipsed &&
1328+
!fileEl.classList.contains('modified')) {
1329+
1330+
// update file in HTML
1331+
fileEl.classList.add('modified');
1332+
1333+
}
1334+
1335+
13201336
// if file is not modified; fetch from Git
13211337
if (!modifiedFiles[fileSha]) {
13221338

@@ -1325,8 +1341,6 @@ async function loadFileInHTML(fileEl, fileSha) {
13251341
startLoading();
13261342
}
13271343

1328-
const fileName = fileEl.querySelector('.name').textContent.replaceAll('\n','');
1329-
13301344
// get file from git
13311345
let resp = await git.getFile(treeLoc, fileName);
13321346

@@ -2933,6 +2947,36 @@ function protectUnsavedCode() {
29332947

29342948
}
29352949

2950+
function protectModFileInSidebar(fileSha, fileName) {
2951+
2952+
// if file is not modified
2953+
if (!modifiedFiles[fileSha]) {
2954+
2955+
// check if old modified file
2956+
// with same name and directory exists
2957+
const oldModFile = Object.values(modifiedFiles).filter(modFile => (modFile.dir === treeLoc.join() && modFile.name === fileName && !modFile.eclipsed))[0];
2958+
2959+
if (oldModFile) {
2960+
2961+
const oldFileSha = oldModFile.sha;
2962+
2963+
// update old modified file with new sha
2964+
oldModFile.sha = fileSha;
2965+
2966+
// save new modified file in local storage
2967+
modifiedFiles[fileSha] = oldModFile;
2968+
2969+
// delete old modified file
2970+
delete modifiedFiles[oldFileSha];
2971+
2972+
updateModFilesLS();
2973+
2974+
}
2975+
2976+
}
2977+
2978+
}
2979+
29362980
function setupEditor() {
29372981

29382982
// if code in storage

lib/plugins/codeit-autolinker.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171

7272
env.attributes.href = href.replaceAll('\'','').replaceAll('"','').replaceAll('`','');
7373
env.attributes.onclick = 'if ((event.ctrlKey || event.metaKey) && event.shiftKey) { event.preventDefault(); window.open(this.href, "_blank") }';
74-
env.attributes.title = isMac ? '⌘ + shift + click to open link' : 'Ctrl + shift + click to open link';
74+
env.attributes.title = isMac ? '⌘ + Shift + click to open link' : 'Ctrl + Shift + click to open link';
7575

7676
// Silently catch any error thrown by decodeURIComponent (#1186)
7777
try {

live-view/live-view.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -699,17 +699,22 @@ if (isMobile) {
699699
});
700700

701701

702-
document.addEventListener('keydown', handleMetaP);
702+
document.addEventListener('keydown', handleMetaR);
703703

704-
function handleMetaP(e) {
704+
function handleMetaR(e) {
705705

706706
// detect ctrl/cmd+R
707707
if ((e.key === 'r' || e.keyCode === 82) && isKeyEventMeta(e)) {
708708

709709
e.preventDefault();
710-
711-
liveView.classList.toggle('visible');
712-
toggleLiveView(selectedFile);
710+
711+
if (selectedFile.lang == 'html' || selectedFile.lang == 'markup' ||
712+
selectedFile.lang === 'markdown') {
713+
714+
liveView.classList.toggle('visible');
715+
toggleLiveView(selectedFile);
716+
717+
}
713718

714719
}
715720

worker/client-channel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55

66
// update worker name when updating worker
7-
const WORKER_NAME = 'codeit-worker-v583';
7+
const WORKER_NAME = 'codeit-worker-v584';
88

99

1010
// internal paths

0 commit comments

Comments
 (0)