refactor: use return instead of echo

Author: kenjis

app/Controllers/DungeonController.php

@@ -4,6 +4,7 @@
 
 use App\Models\DungeonModel;
 use App\Models\HeroModel;
+use CodeIgniter\HTTP\ResponseInterface;
 
 class DungeonController extends BaseController
 {
@@ -28,6 +29,8 @@ public function __construct()
      * The $id parameter is the hero's ID, and is
      * passed in from the route definition as $1,
      * since it is the first placeholder in the route.
+     *
+     * @return ResponseInterface|string
      */
     public function show(int $id)
     {
@@ -37,7 +40,7 @@ public function show(int $id)
             return redirect()->back()->with('error', 'Dungeon not found');
         }
 
-        echo view('dungeon', [
+        return view('dungeon', [
             'dungeon'  => $dungeon,
             'monsters' => $dungeon->monsters(3),
         ]);

app/Controllers/HeroController.php

@@ -14,7 +14,7 @@ class HeroController extends BaseController
      * passed in from the route definition as $1,
      * since it is the first placeholder in the route.
      */
-    public function show(int $id)
+    public function show(int $id): string
     {
         // When you only need to use a model in a single place,
         // you can simply get a new instance here. It will use
@@ -30,10 +30,10 @@ public function show(int $id)
             throw new PageNotFoundException('Hero not found');
         }
 
-        // Display a view file, passing the variables
+        // Return a view, passing the variables
         // you want to access in the view within the
         // second parameter.
-        echo view('hero', [
+        return view('hero', [
             'hero' => $hero,
         ]);
     }